block: Fix block_resize deadlock with iothreads

[PATCH 0/3] block: Fix block_resize deadlock with iothreads

Kevin Wolf posted 3 patches 4 years, 11 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201203172311.68232-1-kwolf@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Fam Zheng <fam@euphon.net>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

block/io.c | 41 ++++++++++++++++++++++++-----------------
blockdev.c | 12 +++++++-----
2 files changed, 31 insertions(+), 22 deletions(-)

Expand all Fold all

[PATCH 0/3] block: Fix block_resize deadlock with iothreads

Posted by Kevin Wolf 4 years, 11 months ago

The conversion of qmp_block_resize() to coroutines exposed a preexisting
locking bug in the drain implementation that can cause deadlocks.

As it happens, fixing this bug reveals in turn that the locking in
qmp_block_resize() itself is incomplete, too.

Kevin Wolf (3):
  block: Simplify qmp_block_resize() error paths
  block: Fix locking in qmp_block_resize()
  block: Fix deadlock in bdrv_co_yield_to_drain()

 block/io.c | 41 ++++++++++++++++++++++++-----------------
 blockdev.c | 12 +++++++-----
 2 files changed, 31 insertions(+), 22 deletions(-)

-- 
2.28.0