Finish cleaning up qemu_init

[PATCH 15/15] monitor: allow quitting while in preconfig state

Paolo Bonzini posted 15 patches 5 years, 2 months ago

Download mbox

Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Michael Roth <mdroth@linux.vnet.ibm.com>, Eduardo Habkost <ehabkost@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Palmer Dabbelt <palmer@dabbelt.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Eric Blake <eblake@redhat.com>, Alistair Francis <Alistair.Francis@wdc.com>, Chris Wulff <crwulff@gmail.com>, Laurent Vivier <laurent@vivier.eu>, Marek Vasut <marex@denx.de>, Richard Henderson <richard.henderson@linaro.org>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Thomas Huth <thuth@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Alex Bennée" <alex.bennee@linaro.org>, Sagar Karandikar <sagark@eecs.berkeley.edu>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Eric Auger <eric.auger@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Markus Armbruster <armbru@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>

Expand all Fold all

[PATCH 15/15] monitor: allow quitting while in preconfig state

Posted by Paolo Bonzini 5 years, 2 months ago

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hmp-commands.hx   | 1 +
 qapi/control.json | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index ff2d7aa8f3..d192afa652 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -45,6 +45,7 @@ ERST
         .params     = "",
         .help       = "quit the emulator",
         .cmd        = hmp_quit,
+        .flags      = "p",
     },
 
 SRST
diff --git a/qapi/control.json b/qapi/control.json
index 134f842baf..1ebc450aad 100644
--- a/qapi/control.json
+++ b/qapi/control.json
@@ -219,7 +219,8 @@
 # -> { "execute": "quit" }
 # <- { "return": {} }
 ##
-{ 'command': 'quit' }
+{ 'command': 'quit',
+  'allow-preconfig': true }
 
 ##
 # @MonitorMode:
-- 
2.26.2

Re: [PATCH 15/15] monitor: allow quitting while in preconfig state

Posted by Igor Mammedov 5 years, 2 months ago

On Wed,  2 Dec 2020 03:18:54 -0500
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hmp-commands.hx   | 1 +
>  qapi/control.json | 3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index ff2d7aa8f3..d192afa652 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -45,6 +45,7 @@ ERST
>          .params     = "",
>          .help       = "quit the emulator",
>          .cmd        = hmp_quit,
> +        .flags      = "p",
>      },
>  
>  SRST
> diff --git a/qapi/control.json b/qapi/control.json
> index 134f842baf..1ebc450aad 100644
> --- a/qapi/control.json
> +++ b/qapi/control.json
> @@ -219,7 +219,8 @@
>  # -> { "execute": "quit" }
>  # <- { "return": {} }
>  ##
> -{ 'command': 'quit' }
> +{ 'command': 'quit',
> +  'allow-preconfig': true }
>  
>  ##
>  # @MonitorMode: