[v2] Categorize some uncategorized devices

[PATCH v2 03/12] vmmouse: put it into the 'input' category

Posted by Gan Qixin 5 years, 2 months ago

The category of the vmmouse device is not set, put it into the 'input'
category.

Signed-off-by: Gan Qixin <ganqixin@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Michael S. Tsirkin <mst@redhat.com>
---
 hw/i386/vmmouse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
index a3556438f0..df4798f502 100644
--- a/hw/i386/vmmouse.c
+++ b/hw/i386/vmmouse.c
@@ -308,6 +308,7 @@ static void vmmouse_class_initfn(ObjectClass *klass, void *data)
     dc->reset = vmmouse_reset;
     dc->vmsd = &vmstate_vmmouse;
     device_class_set_props(dc, vmmouse_properties);
+    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
 }
 
 static const TypeInfo vmmouse_info = {
-- 
2.23.0

Re: [PATCH v2 03/12] vmmouse: put it into the 'input' category

Posted by Laurent Vivier 4 years, 12 months ago

Le 30/11/2020 à 09:36, Gan Qixin a écrit :
> The category of the vmmouse device is not set, put it into the 'input'
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/i386/vmmouse.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
> index a3556438f0..df4798f502 100644
> --- a/hw/i386/vmmouse.c
> +++ b/hw/i386/vmmouse.c
> @@ -308,6 +308,7 @@ static void vmmouse_class_initfn(ObjectClass *klass, void *data)
>      dc->reset = vmmouse_reset;
>      dc->vmsd = &vmstate_vmmouse;
>      device_class_set_props(dc, vmmouse_properties);
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>  
>  static const TypeInfo vmmouse_info = {
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH v2 03/12] vmmouse: put it into the 'input' category

Posted by Thomas Huth 5 years, 1 month ago

On 30/11/2020 09.36, Gan Qixin wrote:
> The category of the vmmouse device is not set, put it into the 'input'
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/i386/vmmouse.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/i386/vmmouse.c b/hw/i386/vmmouse.c
> index a3556438f0..df4798f502 100644
> --- a/hw/i386/vmmouse.c
> +++ b/hw/i386/vmmouse.c
> @@ -308,6 +308,7 @@ static void vmmouse_class_initfn(ObjectClass *klass, void *data)
>      dc->reset = vmmouse_reset;
>      dc->vmsd = &vmstate_vmmouse;
>      device_class_set_props(dc, vmmouse_properties);
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>  
>  static const TypeInfo vmmouse_info = {
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>