[v2] Categorize some uncategorized devices

[PATCH v2 09/12] u2f-passthru: put it into the 'misc' category

Posted by Gan Qixin 5 years, 2 months ago

The category of the u2f-passthru device is not set, put it into the 'misc'
category.

Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/usb/u2f-passthru.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/usb/u2f-passthru.c b/hw/usb/u2f-passthru.c
index ae00e93f35..fc93429c9c 100644
--- a/hw/usb/u2f-passthru.c
+++ b/hw/usb/u2f-passthru.c
@@ -534,6 +534,7 @@ static void u2f_passthru_class_init(ObjectClass *klass, void *data)
     dc->desc = "QEMU U2F passthrough key";
     dc->vmsd = &u2f_passthru_vmstate;
     device_class_set_props(dc, u2f_passthru_properties);
+    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
 }
 
 static const TypeInfo u2f_key_passthru_info = {
-- 
2.23.0

Re: [PATCH v2 09/12] u2f-passthru: put it into the 'misc' category

Posted by Gerd Hoffmann 5 years, 2 months ago

On Mon, Nov 30, 2020 at 04:36:27PM +0800, Gan Qixin wrote:
> The category of the u2f-passthru device is not set, put it into the 'misc'
> category.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

Re: [PATCH v2 09/12] u2f-passthru: put it into the 'misc' category

Posted by Laurent Vivier 4 years, 12 months ago

Le 30/11/2020 à 09:36, Gan Qixin a écrit :
> The category of the u2f-passthru device is not set, put it into the 'misc'
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/usb/u2f-passthru.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/usb/u2f-passthru.c b/hw/usb/u2f-passthru.c
> index ae00e93f35..fc93429c9c 100644
> --- a/hw/usb/u2f-passthru.c
> +++ b/hw/usb/u2f-passthru.c
> @@ -534,6 +534,7 @@ static void u2f_passthru_class_init(ObjectClass *klass, void *data)
>      dc->desc = "QEMU U2F passthrough key";
>      dc->vmsd = &u2f_passthru_vmstate;
>      device_class_set_props(dc, u2f_passthru_properties);
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
>  }
>  
>  static const TypeInfo u2f_key_passthru_info = {
> 

Applied to my trivial-patches branch.

Thanks,
Laurent