[PATCH-for-5.2? 0/4] hw/arm: Add SD bus QOM alias on the machine/soc

Philippe Mathieu-Daudé posted 4 patches 3 years, 5 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201124094941.485767-1-f4bug@amsat.org
hw/arm/exynos4210.c  | 5 +++++
hw/arm/fsl-imx25.c   | 6 ++++++
hw/arm/fsl-imx6.c    | 6 ++++++
hw/arm/xilinx_zynq.c | 6 ++++++
hw/arm/xlnx-versal.c | 5 +++++
5 files changed, 28 insertions(+)
[PATCH-for-5.2? 0/4] hw/arm: Add SD bus QOM alias on the machine/soc
Posted by Philippe Mathieu-Daudé 3 years, 5 months ago
Easy fix for LP#1895895 suggested by Peter.

As TYPE_ASPEED_SDHCI creates SDHCI inside a controller
(not a SoC/machine) we don't bother modifying it yet.

Philippe Mathieu-Daudé (4):
  hw/arm/fsl-imx: Add SD bus QOM alias on the SoC
  hw/arm/exynos4210: Add SD bus QOM alias on the SoC
  hw/arm/xlnx-versal: Add SD bus QOM alias on the SoC
  hw/arm/xilinx_zynq: Add SD bus QOM alias on the machine

 hw/arm/exynos4210.c  | 5 +++++
 hw/arm/fsl-imx25.c   | 6 ++++++
 hw/arm/fsl-imx6.c    | 6 ++++++
 hw/arm/xilinx_zynq.c | 6 ++++++
 hw/arm/xlnx-versal.c | 5 +++++
 5 files changed, 28 insertions(+)

-- 
2.26.2

Re: [PATCH-for-5.2? 0/4] hw/arm: Add SD bus QOM alias on the machine/soc
Posted by Bernhard Beschow 9 months, 3 weeks ago
> Easy fix for LP#1895895 suggested by Peter.
>
> As TYPE_ASPEED_SDHCI creates SDHCI inside a controller
> (not a SoC/machine) we don't bother modifying it yet.
>
> Philippe Mathieu-Daudé (4):
>   hw/arm/fsl-imx: Add SD bus QOM alias on the SoC
>   hw/arm/exynos4210: Add SD bus QOM alias on the SoC
>   hw/arm/xlnx-versal: Add SD bus QOM alias on the SoC
>   hw/arm/xilinx_zynq: Add SD bus QOM alias on the machine
>
>  hw/arm/exynos4210.c  | 5 +++++
>  hw/arm/fsl-imx25.c   | 6 ++++++
>  hw/arm/fsl-imx6.c    | 6 ++++++
>  hw/arm/xilinx_zynq.c | 6 ++++++
>  hw/arm/xlnx-versal.c | 5 +++++
>  5 files changed, 28 insertions(+)

Ping

Re: [PATCH-for-5.2? 0/4] hw/arm: Add SD bus QOM alias on the machine/soc
Posted by Peter Maydell 3 years, 4 months ago
On Tue, 24 Nov 2020 at 09:49, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Easy fix for LP#1895895 suggested by Peter.
>
> As TYPE_ASPEED_SDHCI creates SDHCI inside a controller
> (not a SoC/machine) we don't bother modifying it yet.

So how on the command line do you specify plugging the SD
card into one of the new aliases?

I tried (with the sabrelite machine):
-drive file=/tmp/sdcard.img,format=raw,id=mysdcard -device
sd-card,drive=mysdcard,bus=sd-bus0

but QEMU gives the error:
qemu-system-arm: -device sd-card,drive=mysdcard,bus=sd-bus0: Bus
'sd-bus0' not found

Maybe my idea about the aliases turns out to be wrong ? :-(

thanks
-- PMM