[PATCH v2] usb: fix kconfig for usb-xhci-sysbus

Paolo Bonzini posted 1 patch 4 days, 15 hours ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201120154506.2496906-1-pbonzini@redhat.com
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
hw/usb/Kconfig | 1 -
1 file changed, 1 deletion(-)

[PATCH v2] usb: fix kconfig for usb-xhci-sysbus

Posted by Paolo Bonzini 4 days, 15 hours ago
Remove the "default y" for USB_XHCI_SYSBUS because
sysbus devices are not user creatable; boards that use them will
specify them manually with "imply" or "select" clauses.

It would be nice to keep the ability to remove PCIe and USB from microvm,
since thos can be disabled on the command line and therefore should not
be included if QEMU is configured --without-default-devices.  However
it's too late for 5.2 to figure out a place for the DSDT creation code.

Reported-by: Bruce Rogers <brogers@suse.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/usb/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
index 3b07d9cf68..7fbae18bc8 100644
--- a/hw/usb/Kconfig
+++ b/hw/usb/Kconfig
@@ -47,7 +47,6 @@ config USB_XHCI_NEC
 
 config USB_XHCI_SYSBUS
     bool
-    default y
     select USB_XHCI
 
 config USB_MUSB
-- 
2.26.2


Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus

Posted by Gerd Hoffmann 2 days ago
On Fri, Nov 20, 2020 at 10:45:06AM -0500, Paolo Bonzini wrote:
> Remove the "default y" for USB_XHCI_SYSBUS because
> sysbus devices are not user creatable; boards that use them will
> specify them manually with "imply" or "select" clauses.
> 
> It would be nice to keep the ability to remove PCIe and USB from microvm,
> since thos can be disabled on the command line and therefore should not
> be included if QEMU is configured --without-default-devices.  However
> it's too late for 5.2 to figure out a place for the DSDT creation code.

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>


Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus

Posted by Bruce Rogers 4 days, 14 hours ago
On Fri, 2020-11-20 at 10:45 -0500, Paolo Bonzini wrote:
> Remove the "default y" for USB_XHCI_SYSBUS because
> sysbus devices are not user creatable; boards that use them will
> specify them manually with "imply" or "select" clauses.
> 
> It would be nice to keep the ability to remove PCIe and USB from
> microvm,
> since thos can be disabled on the command line and therefore should
> not
> be included if QEMU is configured --without-default-devices.  However
> it's too late for 5.2 to figure out a place for the DSDT creation
> code.
> 
> Reported-by: Bruce Rogers <brogers@suse.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/usb/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index 3b07d9cf68..7fbae18bc8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -47,7 +47,6 @@ config USB_XHCI_NEC
>  
>  config USB_XHCI_SYSBUS
>      bool
> -    default y
>      select USB_XHCI
>  
>  config USB_MUSB

Tested-by: Bruce Rogers <brogers@suse.com>


Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus

Posted by Philippe Mathieu-Daudé 4 days, 15 hours ago
On 11/20/20 4:45 PM, Paolo Bonzini wrote:
> Remove the "default y" for USB_XHCI_SYSBUS because
> sysbus devices are not user creatable; boards that use them will
> specify them manually with "imply" or "select" clauses.
> 
> It would be nice to keep the ability to remove PCIe and USB from microvm,
> since thos can be disabled on the command line and therefore should not

Typo "those"

> be included if QEMU is configured --without-default-devices.  However
> it's too late for 5.2 to figure out a place for the DSDT creation code.

:(

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Reported-by: Bruce Rogers <brogers@suse.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/usb/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig
> index 3b07d9cf68..7fbae18bc8 100644
> --- a/hw/usb/Kconfig
> +++ b/hw/usb/Kconfig
> @@ -47,7 +47,6 @@ config USB_XHCI_NEC
>  
>  config USB_XHCI_SYSBUS
>      bool
> -    default y
>      select USB_XHCI
>  
>  config USB_MUSB
>