linux-user: Support o32 ABI with 64-bit MIPS CPUs

[PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs

Posted by Philippe Mathieu-Daudé 3 years, 5 months ago

This series allow building linux-user emulator to run ELF
binaries built for the MIPS o32 ABI on 64-bit CPUs (binaries
produced by Sony Linux Toolkit for Playstation 2 for the
R5900 CPU).

The new QEMU binary is named 'qemu-mips64o32'.

The binfmt config isn't correct, as it matches mipsel/mipsn32el.
I missed to understand how mipsel (o32) and mipsn32el (n32) are
differenciated.

Based-on: <20201119160838.1981709-1-f4bug@amsat.org>

Philippe Mathieu-Daudé (4):
  linux-user/mips64: Restore setup_frame() for o32 ABI
  linux-user/mips64: Support o32 ABI syscalls
  default-configs: Support o32 ABI with 64-bit MIPS CPUs
  RFC qemu-binfmt-conf.sh: Add MIPS64 o32 ABI

 docs/user/main.rst                                 | 3 +++
 default-configs/targets/mips64o32el-linux-user.mak | 7 +++++++
 linux-user/mips64/syscall_nr.h                     | 5 ++++-
 linux-user/mips64/target_signal.h                  | 4 ++++
 scripts/qemu-binfmt-conf.sh                        | 4 ++++
 5 files changed, 22 insertions(+), 1 deletion(-)
 create mode 100644 default-configs/targets/mips64o32el-linux-user.mak

-- 
2.26.2

Re: [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs

Posted by no-reply@patchew.org 3 years, 5 months ago

Patchew URL: https://patchew.org/QEMU/20201119161710.1985083-1-f4bug@amsat.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201119161710.1985083-1-f4bug@amsat.org
Subject: [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201119161710.1985083-1-f4bug@amsat.org -> patchew/20201119161710.1985083-1-f4bug@amsat.org
Switched to a new branch 'test'
a58e561 RFC qemu-binfmt-conf.sh: Add MIPS64 o32 ABI
dd1918b default-configs: Support o32 ABI with 64-bit MIPS CPUs
89b6078 linux-user/mips64: Support o32 ABI syscalls
5eacc3e linux-user/mips64: Restore setup_frame() for o32 ABI

=== OUTPUT BEGIN ===
1/4 Checking commit 5eacc3e0fcb8 (linux-user/mips64: Restore setup_frame() for o32 ABI)
2/4 Checking commit 89b6078d6798 (linux-user/mips64: Support o32 ABI syscalls)
3/4 Checking commit dd1918bdda51 (default-configs: Support o32 ABI with 64-bit MIPS CPUs)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 16 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/4 Checking commit a58e5610b2e7 (RFC qemu-binfmt-conf.sh: Add MIPS64 o32 ABI)
ERROR: line over 90 characters
#21: FILE: scripts/qemu-binfmt-conf.sh:71:
+mips64o32el_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x08\x00'

ERROR: line over 90 characters
#22: FILE: scripts/qemu-binfmt-conf.sh:72:
+mips64o32el_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

total: 2 errors, 0 warnings, 10 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201119161710.1985083-1-f4bug@amsat.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs

Posted by Philippe Mathieu-Daudé 3 years, 4 months ago

Hi Laurent,

On 11/19/20 5:17 PM, Philippe Mathieu-Daudé wrote:
> This series allow building linux-user emulator to run ELF
> binaries built for the MIPS o32 ABI on 64-bit CPUs (binaries
> produced by Sony Linux Toolkit for Playstation 2 for the
> R5900 CPU).
> 
> The new QEMU binary is named 'qemu-mips64o32'.
> 
> The binfmt config isn't correct, as it matches mipsel/mipsn32el.
> I missed to understand how mipsel (o32) and mipsn32el (n32) are
> differentiated.
> 

> Philippe Mathieu-Daudé (4):
>   linux-user/mips64: Restore setup_frame() for o32 ABI
>   linux-user/mips64: Support o32 ABI syscalls

Until we figure out the issue raised by Maciej in patch 3,
can you review/queue patches 1 and 2 which are independent
of the outcome?

Thanks,

Phil.

Re: [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs

Posted by Philippe Mathieu-Daudé 3 years, 2 months ago

ping?

On 12/13/20 4:14 PM, Philippe Mathieu-Daudé wrote:
> Hi Laurent,
> 
> On 11/19/20 5:17 PM, Philippe Mathieu-Daudé wrote:
>> This series allow building linux-user emulator to run ELF
>> binaries built for the MIPS o32 ABI on 64-bit CPUs (binaries
>> produced by Sony Linux Toolkit for Playstation 2 for the
>> R5900 CPU).
>>
>> The new QEMU binary is named 'qemu-mips64o32'.
>>
>> The binfmt config isn't correct, as it matches mipsel/mipsn32el.
>> I missed to understand how mipsel (o32) and mipsn32el (n32) are
>> differentiated.
>>
> 
>> Philippe Mathieu-Daudé (4):
>>   linux-user/mips64: Restore setup_frame() for o32 ABI
>>   linux-user/mips64: Support o32 ABI syscalls
> 
> Until we figure out the issue raised by Maciej in patch 3,
> can you review/queue patches 1 and 2 which are independent
> of the outcome?
> 
> Thanks,
> 
> Phil.
>