[PATCH 1/6] configure: Remove the obsolete check for ifaddrs.h

Thomas Huth posted 6 patches 5 years, 2 months ago
Maintainers: Laurent Vivier <laurent@vivier.eu>
[PATCH 1/6] configure: Remove the obsolete check for ifaddrs.h
Posted by Thomas Huth 5 years, 2 months ago
The code that used HAVE_IFADDRS_H has been removed in commit
0a27af918b ("io: use bind() to check for IPv4/6 availability"),
so we don't need this check in the configure script anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 configure | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/configure b/configure
index 714e75b5d8..6c8f56c514 100755
--- a/configure
+++ b/configure
@@ -3094,14 +3094,6 @@ EOF
     fi
 fi
 
-##########################################
-# getifaddrs (for tests/test-io-channel-socket )
-
-have_ifaddrs_h=yes
-if ! check_include "ifaddrs.h" ; then
-  have_ifaddrs_h=no
-fi
-
 #########################################
 # libdrm check
 have_drm_h=no
@@ -6199,9 +6191,6 @@ fi
 if test "$auth_pam" = "yes" ; then
     echo "CONFIG_AUTH_PAM=y" >> $config_host_mak
 fi
-if test "$have_ifaddrs_h" = "yes" ; then
-    echo "HAVE_IFADDRS_H=y" >> $config_host_mak
-fi
 if test "$have_drm_h" = "yes" ; then
   echo "HAVE_DRM_H=y" >> $config_host_mak
 fi
-- 
2.18.4


Re: [PATCH 1/6] configure: Remove the obsolete check for ifaddrs.h
Posted by Richard Henderson 5 years, 2 months ago
On 11/18/20 9:10 AM, Thomas Huth wrote:
> The code that used HAVE_IFADDRS_H has been removed in commit
> 0a27af918b ("io: use bind() to check for IPv4/6 availability"),
> so we don't need this check in the configure script anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 11 -----------
>  1 file changed, 11 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH 1/6] configure: Remove the obsolete check for ifaddrs.h
Posted by Laurent Vivier 5 years, 1 month ago
Le 18/11/2020 à 18:10, Thomas Huth a écrit :
> The code that used HAVE_IFADDRS_H has been removed in commit
> 0a27af918b ("io: use bind() to check for IPv4/6 availability"),
> so we don't need this check in the configure script anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  configure | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/configure b/configure
> index 714e75b5d8..6c8f56c514 100755
> --- a/configure
> +++ b/configure
> @@ -3094,14 +3094,6 @@ EOF
>      fi
>  fi
>  
> -##########################################
> -# getifaddrs (for tests/test-io-channel-socket )
> -
> -have_ifaddrs_h=yes
> -if ! check_include "ifaddrs.h" ; then
> -  have_ifaddrs_h=no
> -fi
> -
>  #########################################
>  # libdrm check
>  have_drm_h=no
> @@ -6199,9 +6191,6 @@ fi
>  if test "$auth_pam" = "yes" ; then
>      echo "CONFIG_AUTH_PAM=y" >> $config_host_mak
>  fi
> -if test "$have_ifaddrs_h" = "yes" ; then
> -    echo "HAVE_IFADDRS_H=y" >> $config_host_mak
> -fi
>  if test "$have_drm_h" = "yes" ; then
>    echo "HAVE_DRM_H=y" >> $config_host_mak
>  fi
> 

Applied to my trivial-patches branch.

Thanks,
Laurent