[PATCH] cirrus-ci: parallelize "make check"

Paolo Bonzini posted 1 patch 3 years, 5 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201118101821.132236-1-pbonzini@redhat.com
Maintainers: Li-Wen Hsu <lwhsu@freebsd.org>, Ed Maste <emaste@freebsd.org>
.cirrus.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] cirrus-ci: parallelize "make check"
Posted by Paolo Bonzini 3 years, 5 months ago
Otherwise, the tests risk failing due to timeouts.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 .cirrus.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.cirrus.yml b/.cirrus.yml
index f0209b7a3e..111e19f1bf 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -29,7 +29,7 @@ macos_task:
                    --extra-cflags='-Wno-error=deprecated-declarations'
                    || { cat config.log meson-logs/meson-log.txt; exit 1; }
     - gmake -j$(sysctl -n hw.ncpu)
-    - gmake check V=1
+    - gmake -j$(sysctl -n hw.ncpu) check V=1
 
 macos_xcode_task:
   osx_instance:
@@ -43,7 +43,7 @@ macos_xcode_task:
     - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules
                    --enable-werror --cc=clang || { cat config.log meson-logs/meson-log.txt; exit 1; }
     - gmake -j$(sysctl -n hw.ncpu)
-    - gmake check V=1
+    - gmake -j$(sysctl -n hw.ncpu) check V=1
 
 windows_msys2_task:
   timeout_in: 90m
-- 
2.28.0


Re: [PATCH] cirrus-ci: parallelize "make check"
Posted by Alex Bennée 3 years, 5 months ago
Paolo Bonzini <pbonzini@redhat.com> writes:

> Otherwise, the tests risk failing due to timeouts.

This is a reversion of what we used to do because it's very hard to
figure out which test broke when they are all mixed together. Maybe we
could just up the timeouts.

That said the timeouts seem a bit random with macos taking around 53
minutes and macos_xcode taking less at around 44 unless they get "stuck".

>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  .cirrus.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.cirrus.yml b/.cirrus.yml
> index f0209b7a3e..111e19f1bf 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -29,7 +29,7 @@ macos_task:
>                     --extra-cflags='-Wno-error=deprecated-declarations'
>                     || { cat config.log meson-logs/meson-log.txt; exit 1; }
>      - gmake -j$(sysctl -n hw.ncpu)
> -    - gmake check V=1
> +    - gmake -j$(sysctl -n hw.ncpu) check V=1
>  
>  macos_xcode_task:
>    osx_instance:
> @@ -43,7 +43,7 @@ macos_xcode_task:
>      - ../configure --extra-cflags='-Wno-error=deprecated-declarations' --enable-modules
>                     --enable-werror --cc=clang || { cat config.log meson-logs/meson-log.txt; exit 1; }
>      - gmake -j$(sysctl -n hw.ncpu)
> -    - gmake check V=1
> +    - gmake -j$(sysctl -n hw.ncpu) check V=1
>  
>  windows_msys2_task:
>    timeout_in: 90m


-- 
Alex Bennée

Re: [PATCH] cirrus-ci: parallelize "make check"
Posted by Paolo Bonzini 3 years, 5 months ago
On 18/11/20 13:49, Alex Bennée wrote:
> 
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
>> Otherwise, the tests risk failing due to timeouts.
> 
> This is a reversion of what we used to do because it's very hard to
> figure out which test broke when they are all mixed together. Maybe we
> could just up the timeouts.

Ah, I see.  Yeah, that's a problem too. :(

> That said the timeouts seem a bit random with macos taking around 53
> minutes and macos_xcode taking less at around 44 unless they get "stuck".

Yes, Cirrus load varies quite a bit.

Paolo