[RFC v7 00/26] vSMMUv3/pSMMUv3 2 stage VFIO integration

Eric Auger posted 26 patches 3 years, 5 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201116181349.11908-1-eric.auger@redhat.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Cornelia Huck <cohuck@redhat.com>, Eric Auger <eric.auger@redhat.com>, Alex Williamson <alex.williamson@redhat.com>
There is a newer version of this series
hw/vfio/pci.h                                 |  11 +
include/exec/memory.h                         |  48 +-
include/hw/arm/smmu-common.h                  |   1 +
include/hw/iommu/iommu.h                      |  36 ++
include/hw/pci/pci.h                          |  15 +
include/hw/vfio/vfio-common.h                 |  16 +
include/standard-headers/asm-x86/kvm_para.h   |   1 +
.../infiniband/hw/vmw_pvrdma/pvrdma_ring.h    |  14 +-
.../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h   |   2 +-
include/standard-headers/linux/vhost_types.h  |   9 +
linux-headers/linux/iommu.h                   | 395 +++++++++++++
linux-headers/linux/vfio.h                    | 140 ++++-
linux-headers/linux/vhost.h                   |   4 +
hw/arm/smmuv3.c                               | 184 +++++-
hw/pci/pci.c                                  |  50 ++
hw/vfio/common.c                              | 527 ++++++++++++++----
hw/vfio/pci.c                                 | 388 ++++++++++++-
softmmu/memory.c                              |  10 +
hw/arm/trace-events                           |   1 +
hw/vfio/trace-events                          |   9 +-
scripts/update-linux-headers.sh               |   2 +-
21 files changed, 1705 insertions(+), 158 deletions(-)
create mode 100644 include/hw/iommu/iommu.h
create mode 100644 linux-headers/linux/iommu.h
[RFC v7 00/26] vSMMUv3/pSMMUv3 2 stage VFIO integration
Posted by Eric Auger 3 years, 5 months ago
Up to now vSMMUv3 has not been integrated with VFIO. VFIO
integration requires to program the physical IOMMU consistently
with the guest mappings. However, as opposed to VTD, SMMUv3 has
no "Caching Mode" which allows easy trapping of guest mappings.
This means the vSMMUV3 cannot use the same VFIO integration as VTD.

However SMMUv3 has 2 translation stages. This was devised with
virtualization use case in mind where stage 1 is "owned" by the
guest whereas the host uses stage 2 for VM isolation.

This series sets up this nested translation stage. It only works
if there is one physical SMMUv3 used along with QEMU vSMMUv3 (in
other words, it does not work if there is a physical SMMUv2).

- We force the host to use stage 2 instead of stage 1, when we
  detect a vSMMUV3 is behind a VFIO device. For a VFIO device
  without any virtual IOMMU, we still use stage 1 as many existing
  SMMUs expect this behavior.
- We use PCIPASIDOps to propage guest stage1 config changes on
  STE (Stream Table Entry) changes.
- We implement a specific UNMAP notifier that conveys guest
  IOTLB invalidations to the host
- We register MSI IOVA/GPA bindings to the host so that this latter
  can build a nested stage translation
- As the legacy MAP notifier is not called anymore, we must make
  sure stage 2 mappings are set. This is achieved through another
  prereg memory listener.
- Physical SMMU stage 1 related faults are reported to the guest
  via en eventfd mechanism and exposed trhough a dedicated VFIO-PCI
  region. Then they are reinjected into the guest.

Best Regards

Eric

This series can be found at:
https://github.com/eauger/qemu/tree/v5.2.0-rc1-2stage-rfcv7

Kernel Dependencies:
[1] [PATCH v12 00/15] SMMUv3 Nested Stage Setup (IOMMU part)
[2] [PATCH v11 00/13] SMMUv3 Nested Stage Setup (VFIO part)
branch containing both:
https://github.com/eauger/linux/tree/5.10-rc4-2stage-v12

History:

v6 -> v7:
- rebase on v5.2.0-rc1
- added:
  "pci: Add return_page_response pci ops" and
  "vfio/pci: Implement return_page_response page response callback"
  for vSVA integration (not used in this series).

v5 -> v6:
- just rebase work

v4 -> v5:
- Use PCIPASIDOps for config update notifications
- removal of notification for MSI binding which is not needed
  anymore
- Use a single fault region
- use the specific interrupt index

v3 -> v4:
- adapt to changes in uapi (asid cache invalidation)
- check VFIO_PCI_DMA_FAULT_IRQ_INDEX is supported at kernel level
  before attempting to set signaling for it.
- sync on 5.2-rc1 kernel headers + Drew's patch that imports sve_context.h
- fix MSI binding for MSI (not MSIX)
- fix mingw compilation

v2 -> v3:
- rework fault handling
- MSI binding registration done in vfio-pci. MSI binding tear down called
  on container cleanup path
- leaf parameter propagated

v1 -> v2:
- Fixed dual assignment (asid now correctly propagated on TLB invalidations)
- Integrated fault reporting

Eric Auger (25):
  update-linux-headers: Import iommu.h
  header update against 5.10-rc4 and IOMMU/VFIO nested stage APIs
  memory: Add IOMMU_ATTR_VFIO_NESTED IOMMU memory region attribute
  memory: Add IOMMU_ATTR_MSI_TRANSLATE IOMMU memory region attribute
  memory: Introduce IOMMU Memory Region inject_faults API
  memory: Add arch_id and leaf fields in IOTLBEntry
  iommu: Introduce generic header
  vfio: Force nested if iommu requires it
  vfio: Introduce hostwin_from_range helper
  vfio: Introduce helpers to DMA map/unmap a RAM section
  vfio: Set up nested stage mappings
  vfio: Pass stage 1 MSI bindings to the host
  vfio: Helper to get IRQ info including capabilities
  vfio/pci: Register handler for iommu fault
  vfio/pci: Set up the DMA FAULT region
  vfio/pci: Implement the DMA fault handler
  hw/arm/smmuv3: Advertise MSI_TRANSLATE attribute
  hw/arm/smmuv3: Store the PASID table GPA in the translation config
  hw/arm/smmuv3: Fill the IOTLBEntry arch_id on NH_VA invalidation
  hw/arm/smmuv3: Fill the IOTLBEntry leaf field on NH_VA invalidation
  hw/arm/smmuv3: Pass stage 1 configurations to the host
  hw/arm/smmuv3: Implement fault injection
  hw/arm/smmuv3: Allow MAP notifiers
  pci: Add return_page_response pci ops
  vfio/pci: Implement return_page_response page response callback

Liu Yi L (1):
  pci: introduce PCIPASIDOps to PCIDevice

 hw/vfio/pci.h                                 |  11 +
 include/exec/memory.h                         |  48 +-
 include/hw/arm/smmu-common.h                  |   1 +
 include/hw/iommu/iommu.h                      |  36 ++
 include/hw/pci/pci.h                          |  15 +
 include/hw/vfio/vfio-common.h                 |  16 +
 include/standard-headers/asm-x86/kvm_para.h   |   1 +
 .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h    |  14 +-
 .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h   |   2 +-
 include/standard-headers/linux/vhost_types.h  |   9 +
 linux-headers/linux/iommu.h                   | 395 +++++++++++++
 linux-headers/linux/vfio.h                    | 140 ++++-
 linux-headers/linux/vhost.h                   |   4 +
 hw/arm/smmuv3.c                               | 184 +++++-
 hw/pci/pci.c                                  |  50 ++
 hw/vfio/common.c                              | 527 ++++++++++++++----
 hw/vfio/pci.c                                 | 388 ++++++++++++-
 softmmu/memory.c                              |  10 +
 hw/arm/trace-events                           |   1 +
 hw/vfio/trace-events                          |   9 +-
 scripts/update-linux-headers.sh               |   2 +-
 21 files changed, 1705 insertions(+), 158 deletions(-)
 create mode 100644 include/hw/iommu/iommu.h
 create mode 100644 linux-headers/linux/iommu.h

-- 
2.21.3