[PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build

Thomas Huth posted 4 patches 5 years, 2 months ago
Maintainers: Eric Blake <eblake@redhat.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>
[PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build
Posted by Thomas Huth 5 years, 2 months ago
The Haiku VM that we are going to add is using _BSD_SOURCE instead
of BSD_SOURCE (without initial underscore)... according to David
Carlier, the BSD_SOURCE without underscore was likely a typo, so
let's simply add the underscore there now.
This fixes the build failure with the bswapXX() macros not being
defined after including <endian.h>.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 4cef321d9d..a273a93377 100755
--- a/configure
+++ b/configure
@@ -790,7 +790,7 @@ SunOS)
 ;;
 Haiku)
   haiku="yes"
-  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -DBSD_SOURCE $QEMU_CFLAGS"
+  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE $QEMU_CFLAGS"
 ;;
 Linux)
   audio_drv_list="try-pa oss"
-- 
2.18.4


Re: [PATCH 1/4] configure: Fix the _BSD_SOURCE define for the Haiku build
Posted by Stefan Berger 5 years, 2 months ago
On 11/14/20 11:51 AM, Thomas Huth wrote:
> The Haiku VM that we are going to add is using _BSD_SOURCE instead
> of BSD_SOURCE (without initial underscore)... according to David
> Carlier, the BSD_SOURCE without underscore was likely a typo, so
> let's simply add the underscore there now.
> This fixes the build failure with the bswapXX() macros not being
> defined after including <endian.h>.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4cef321d9d..a273a93377 100755
> --- a/configure
> +++ b/configure
> @@ -790,7 +790,7 @@ SunOS)
>   ;;
>   Haiku)
>     haiku="yes"
> -  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -DBSD_SOURCE $QEMU_CFLAGS"
> +  QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE $QEMU_CFLAGS"
>   ;;
>   Linux)
>     audio_drv_list="try-pa oss"

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com