[PATCH] io_uring: do not use pointer after free

Paolo Bonzini posted 1 patch 3 years, 5 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201113154102.1460459-1-pbonzini@redhat.com
Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Aarushi Mehta <mehta.aaru20@gmail.com>, Max Reitz <mreitz@redhat.com>, Julia Suvorova <jusual@redhat.com>, Kevin Wolf <kwolf@redhat.com>
block/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] io_uring: do not use pointer after free
Posted by Paolo Bonzini 3 years, 5 months ago
Even though only the pointer value is only printed, it is untidy
and Coverity complains.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/io_uring.c b/block/io_uring.c
index 037af09471..00a3ee9fb8 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -425,6 +425,6 @@ LuringState *luring_init(Error **errp)
 void luring_cleanup(LuringState *s)
 {
     io_uring_queue_exit(&s->ring);
-    g_free(s);
     trace_luring_cleanup_state(s);
+    g_free(s);
 }
-- 
2.26.2


Re: [PATCH-for-5.2] io_uring: do not use pointer after free
Posted by Philippe Mathieu-Daudé 3 years, 5 months ago
On 11/13/20 4:41 PM, Paolo Bonzini wrote:
> Even though only the pointer value is only printed, it is untidy
> and Coverity complains.
> 
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/io_uring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


Re: [PATCH] io_uring: do not use pointer after free
Posted by Kevin Wolf 3 years, 5 months ago
Am 13.11.2020 um 16:41 hat Paolo Bonzini geschrieben:
> Even though only the pointer value is only printed, it is untidy
> and Coverity complains.
> 
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, applied to the block branch.

Kevin