[v1] Misc fixes for QEMU 5.2-rc2

[PULL 0/6] Misc fixes for QEMU 5.2-rc2

Posted by Paolo Bonzini 3 years, 5 months ago

The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into staging (2020-11-06 13:43:28 +0000)

are available in the Git repository at:

  https://gitlab.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 6e853291036573c8831f486fc7d76b779b0ac567:

  pvpanic: Advertise the PVPANIC_CRASHLOADED event support (2020-11-10 06:27:17 -0500)

----------------------------------------------------------------
Bug fixes

----------------------------------------------------------------
Greg Kurz (1):
      Makefile: No echoing for 'make help V=1'

Pankaj Gupta (1):
      physmem: improve ram size error messages

Paolo Bonzini (2):
      fix make clean/distclean
      pvpanic: Advertise the PVPANIC_CRASHLOADED event support

Pavel Dovgalyuk (1):
      replay: remove some dead code

Thomas Huth (1):
      meson: Clarify the confusing vhost-user vs. vhost-kernel output

 Makefile                  | 8 ++++----
 hw/core/machine.c         | 1 +
 hw/misc/pvpanic.c         | 5 ++++-
 meson.build               | 3 ++-
 replay/replay-debugging.c | 3 ---
 softmmu/physmem.c         | 6 +++---
 6 files changed, 14 insertions(+), 12 deletions(-)
-- 
2.26.2

Re: [PULL 0/6] Misc fixes for QEMU 5.2-rc2

Posted by no-reply@patchew.org 3 years, 5 months ago

Patchew URL: https://patchew.org/QEMU/20201110112909.1103518-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20201110112909.1103518-1-pbonzini@redhat.com
Subject: [PULL 0/6] Misc fixes for QEMU 5.2-rc2
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201110112909.1103518-1-pbonzini@redhat.com -> patchew/20201110112909.1103518-1-pbonzini@redhat.com
Switched to a new branch 'test'
34b22cb pvpanic: Advertise the PVPANIC_CRASHLOADED event support
594f3dd physmem: improve ram size error messages
336e122 Makefile: No echoing for 'make help V=1'
ef0af38 replay: remove some dead code
ba7f98d fix make clean/distclean
37d6f0b meson: Clarify the confusing vhost-user vs. vhost-kernel output

=== OUTPUT BEGIN ===
1/6 Checking commit 37d6f0b2395b (meson: Clarify the confusing vhost-user vs. vhost-kernel output)
2/6 Checking commit ba7f98d02bcf (fix make clean/distclean)
3/6 Checking commit ef0af387b70a (replay: remove some dead code)
4/6 Checking commit 336e12250515 (Makefile: No echoing for 'make help V=1')
5/6 Checking commit 594f3dd09101 (physmem: improve ram size error messages)
6/6 Checking commit 34b22cb0d95e (pvpanic: Advertise the PVPANIC_CRASHLOADED event support)
ERROR: line over 90 characters
#53: FILE: hw/misc/pvpanic.c:117:
+    DEFINE_PROP_UINT8("events", PVPanicState, events, PVPANIC_PANICKED | PVPANIC_CRASHLOADED),

total: 1 errors, 0 warnings, 29 lines checked

Patch 6/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201110112909.1103518-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL 0/6] Misc fixes for QEMU 5.2-rc2

Posted by Peter Maydell 3 years, 5 months ago

On Tue, 10 Nov 2020 at 11:35, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> The following changes since commit 3493c36f0371777c62d1d72b205b0eb6117e2156:
>
>   Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20201106' into staging (2020-11-06 13:43:28 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 6e853291036573c8831f486fc7d76b779b0ac567:
>
>   pvpanic: Advertise the PVPANIC_CRASHLOADED event support (2020-11-10 06:27:17 -0500)
>
> ----------------------------------------------------------------
> Bug fixes
>
> ----------------------------------------------------------------

Fails "make check" on all platforms:

MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_IMG=./qemu-img G_TEST_DBUS_DAEMON=/home/petmay
01/linaro/qemu-for-merges/tests/dbus-vmstate-daemon.sh
QTEST_QEMU_BINARY=./qemu-system-i386 tests/qtest/pvpanic-test --tap
 -k
**
ERROR:../../tests/qtest/pvpanic-test.c:23:test_panic: assertion failed
(val == 1): (3 == 1)
ERROR qtest-i386/pvpanic-test - Bail out!
ERROR:../../tests/qtest/pvpanic-test.c:23:test_panic: assertion failed
(val == 1): (3 == 1)

thanks
-- PMM