accel: Remove system-mode stubs from user-mode builds

[PATCH 0/3] accel: Remove system-mode stubs from user-mode builds

Philippe Mathieu-Daudé posted 3 patches 3 years, 5 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201109094547.2456385-1-f4bug@amsat.org

accel/stubs/kvm-stub.c  |  5 -----
accel/meson.build       | 10 ++++++----
accel/stubs/meson.build | 12 ++++++++----
3 files changed, 14 insertions(+), 13 deletions(-)

Expand all Fold all

[PATCH 0/3] accel: Remove system-mode stubs from user-mode builds

Posted by Philippe Mathieu-Daudé 3 years, 5 months ago

It is pointless to build/link these stubs into user-mode binaries.

Philippe Mathieu-Daudé (3):
  accel: Only include TCG stubs in user-mode only builds
  accel/stubs: Restrict system-mode emulation stubs
  accel/stubs: Simplify kvm-stub.c

 accel/stubs/kvm-stub.c  |  5 -----
 accel/meson.build       | 10 ++++++----
 accel/stubs/meson.build | 12 ++++++++----
 3 files changed, 14 insertions(+), 13 deletions(-)

-- 
2.26.2

Re: [PATCH 0/3] accel: Remove system-mode stubs from user-mode builds

Posted by Paolo Bonzini 3 years, 5 months ago

On 09/11/20 10:45, Philippe Mathieu-Daudé wrote:
> It is pointless to build/link these stubs into user-mode binaries.
> 
> Philippe Mathieu-Daudé (3):
>    accel: Only include TCG stubs in user-mode only builds
>    accel/stubs: Restrict system-mode emulation stubs
>    accel/stubs: Simplify kvm-stub.c
> 
>   accel/stubs/kvm-stub.c  |  5 -----
>   accel/meson.build       | 10 ++++++----
>   accel/stubs/meson.build | 12 ++++++++----
>   3 files changed, 14 insertions(+), 13 deletions(-)
> 

The series makes sense.  It probably also shows that it makes sense to 
have a "specific_softmmu_ss" sourceset in meson.build.  Let's review 
Alex Bennée's patches and then get back to this one.

Paolo