[v3] gitlab-ci: Allow forks to select & restrict build jobs

[PATCH v3 01/11] gitlab-ci: Drop generic cache rule

Posted by Philippe Mathieu-Daudé 5 years, 3 months ago

This cache rule is meant for Avocado artifacts, but affects
all jobs. Moreover the 'acceptance_template' template already
include a more detailled rule to cache artifacts.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.yml | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 3b15ae5c302..5763318d375 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -7,12 +7,6 @@ stages:
   - build
   - test
 
-# We assume GitLab has it's own caching set up for RPM/APT repositories so we
-# just take care of avocado assets here.
-cache:
-  paths:
-    - $HOME/avocado/data/cache
-
 include:
   - local: '/.gitlab-ci.d/edk2.yml'
   - local: '/.gitlab-ci.d/opensbi.yml'
-- 
2.26.2

Re: [PATCH v3 01/11] gitlab-ci: Drop generic cache rule

Posted by Thomas Huth 5 years, 3 months ago

On 08/11/2020 23.19, Philippe Mathieu-Daudé wrote:
> This cache rule is meant for Avocado artifacts, but affects
> all jobs. Moreover the 'acceptance_template' template already
> include a more detailled rule to cache artifacts.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.yml | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 3b15ae5c302..5763318d375 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -7,12 +7,6 @@ stages:
>    - build
>    - test
>  
> -# We assume GitLab has it's own caching set up for RPM/APT repositories so we
> -# just take care of avocado assets here.
> -cache:
> -  paths:
> -    - $HOME/avocado/data/cache

Right, IIRC the path in $HOME wasn't working as expected anyway, that's why
we switched to a more complicated logic in the acceptance_template.

Reviewed-by: Thomas Huth <thuth@redhat.com>