[PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options

Philippe Mathieu-Daudé posted 17 patches 5 years, 3 months ago
[PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options
Posted by Philippe Mathieu-Daudé 5 years, 3 months ago
Add these missing options to the 'build-disabled' job:
  --disable-auth-pam             (commit 8953caf3cd38)
  --disable-gcrypt               (commit 91bfcdb01d48)
  --disable-keyring              (commit 54e7aac05624)
  --disable-libudev              (commit 5c53015a480b)
  --disable-opengl               (commit da076ffed6b9)
  --disable-sparse               (commit 03b4fe7de226)

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.yml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9f090cca5e3..b98800462ed 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -205,6 +205,7 @@ build-disabled:
     IMAGE: fedora
     CONFIGURE_ARGS:
       --disable-attr
+      --disable-auth-pam
       --disable-avx2
       --disable-bochs
       --disable-brlapi
@@ -217,15 +218,18 @@ build-disabled:
       --disable-curses
       --disable-dmg
       --disable-docs
+      --disable-gcrypt
       --disable-glusterfs
       --disable-gnutls
       --disable-gtk
       --disable-guest-agent
       --disable-iconv
+      --disable-keyring
       --disable-kvm
       --disable-libiscsi
       --disable-libpmem
       --disable-libssh
+      --disable-libudev
       --disable-libusb
       --disable-libxml2
       --disable-linux-aio
@@ -235,6 +239,7 @@ build-disabled:
       --disable-mpath
       --disable-nettle
       --disable-numa
+      --disable-opengl
       --disable-parallels
       --disable-pie
       --disable-qcow1
@@ -249,6 +254,7 @@ build-disabled:
       --disable-slirp
       --disable-smartcard
       --disable-snappy
+      --disable-sparse
       --disable-spice
       --disable-strip
       --disable-tpm
@@ -258,6 +264,7 @@ build-disabled:
       --disable-vhost-net
       --disable-vhost-scsi
       --disable-vhost-user
+      --disable-vhost-user-blk-server
       --disable-vhost-vdpa
       --disable-vhost-vsock
       --disable-virglrenderer
-- 
2.26.2

Re: [PATCH-for-6.0 v4 06/17] gitlab-ci: Update 'build-disabled' to cover all configurable options
Posted by Thomas Huth 5 years, 3 months ago
On 08/11/2020 21.45, Philippe Mathieu-Daudé wrote:
> Add these missing options to the 'build-disabled' job:
>   --disable-auth-pam             (commit 8953caf3cd38)
>   --disable-gcrypt               (commit 91bfcdb01d48)
>   --disable-keyring              (commit 54e7aac05624)
>   --disable-libudev              (commit 5c53015a480b)
>   --disable-opengl               (commit da076ffed6b9)
>   --disable-sparse               (commit 03b4fe7de226)
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  .gitlab-ci.yml | 7 +++++++
>  1 file changed, 7 insertions(+)
[...]
> @@ -258,6 +264,7 @@ build-disabled:
>        --disable-vhost-net
>        --disable-vhost-scsi
>        --disable-vhost-user
> +      --disable-vhost-user-blk-server
>        --disable-vhost-vdpa
>        --disable-vhost-vsock
>        --disable-virglrenderer

vhost-user-blk-server should get automatically disabled by
--disable-vhost-user ... so maybe drop this hunk, so that we're able to
detect problems with this logic in the future, too? (as we've just seen with
the current build failures in the CI)
... if you insist on keeping this hunk, I think you should at least mention
it in the patch description (since you've mentioned all the other options there)

 Thomas