configure: fix gio_libs reference

[PATCH] configure: fix gio_libs reference

Bruce Rogers posted 1 patch 3 years, 6 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201103145121.668865-1-brogers@suse.com

configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] configure: fix gio_libs reference

Posted by Bruce Rogers 3 years, 6 months ago

The gio library detection code no longer works, due to a missing $ in
front of the gio_libs reference. Make the string be $gio_libs.

Fixes: 76346b6264a ("configure: Test that gio libs from pkg-config
work")

Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 2c3c69f118..bc06aa81e5 100755
--- a/configure
+++ b/configure
@@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
     # with pkg-config --static --libs data for gio-2.0 that is missing
     # -lblkid and will give a link error.
     write_c_skeleton
-    if compile_prog "" "gio_libs" ; then
+    if compile_prog "" "$gio_libs" ; then
         gio=yes
     else
         gio=no
-- 
2.29.0

Re: [PATCH] configure: fix gio_libs reference

Posted by Paolo Bonzini 3 years, 6 months ago

On 03/11/20 15:51, Bruce Rogers wrote:
> The gio library detection code no longer works, due to a missing $ in
> front of the gio_libs reference. Make the string be $gio_libs.
> 
> Fixes: 76346b6264a ("configure: Test that gio libs from pkg-config
> work")
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 2c3c69f118..bc06aa81e5 100755
> --- a/configure
> +++ b/configure
> @@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
>      # with pkg-config --static --libs data for gio-2.0 that is missing
>      # -lblkid and will give a link error.
>      write_c_skeleton
> -    if compile_prog "" "gio_libs" ; then
> +    if compile_prog "" "$gio_libs" ; then
>          gio=yes
>      else
>          gio=no
> 

Queued, thanks.

Paolo