1. Patchew
  2. QEMU
  3. View series

[PATCH] target/i386: tracing: format length values as hex

Dov Murik posted 1 patch 3 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201103100745.160409-1-dovmurik@linux.vnet.ibm.com
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>
target/i386/trace-events | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] target/i386: tracing: format length values as hex
Posted by Dov Murik 3 years, 6 months ago 
Three trace events had a literal "0x" prefix but the 'len' values were
formatted in decimal base.  Keep the prefix and format the numbers as
hex, as is usually the case for length of memory regions.

Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
---
 target/i386/trace-events | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/i386/trace-events b/target/i386/trace-events
index 789c700d4a..65c9b0fdda 100644
--- a/target/i386/trace-events
+++ b/target/i386/trace-events
@@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
 
 # sev.c
 kvm_sev_init(void) ""
-kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
-kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
+kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
+kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
 kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
 kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
-kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
+kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
 kvm_sev_launch_measurement(const char *value) "data %s"
 kvm_sev_launch_finish(void) ""
-- 
2.20.1
Re: [PATCH] target/i386: tracing: format length values as hex
Posted by Philippe Mathieu-Daudé 3 years, 6 months ago 
On 11/3/20 11:07 AM, Dov Murik wrote:
> Three trace events had a literal "0x" prefix but the 'len' values were
> formatted in decimal base.  Keep the prefix and format the numbers as
> hex, as is usually the case for length of memory regions.
> 
> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
> ---
>  target/i386/trace-events | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Re: [PATCH] target/i386: tracing: format length values as hex
Posted by Dov Murik 3 years, 4 months ago 
ping

Adding CC qemu-trivial.

This already got one R-b:
https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html

-Dov


On 03/11/2020 12:07, Dov Murik wrote:
> Three trace events had a literal "0x" prefix but the 'len' values were
> formatted in decimal base.  Keep the prefix and format the numbers as
> hex, as is usually the case for length of memory regions.
> 
> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
> ---
>   target/i386/trace-events | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/i386/trace-events b/target/i386/trace-events
> index 789c700d4a..65c9b0fdda 100644
> --- a/target/i386/trace-events
> +++ b/target/i386/trace-events
> @@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
> 
>   # sev.c
>   kvm_sev_init(void) ""
> -kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
> -kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
> +kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
> +kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
>   kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
>   kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
> -kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
> +kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
>   kvm_sev_launch_measurement(const char *value) "data %s"
>   kvm_sev_launch_finish(void) ""
>
Re: [PATCH] target/i386: tracing: format length values as hex
Posted by Laurent Vivier 3 years, 4 months ago 
Le 09/12/2020 à 18:58, Dov Murik a écrit :
> ping
> 
> Adding CC qemu-trivial.
> 
> This already got one R-b:
> https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html
> 
> -Dov
> 
> 
> On 03/11/2020 12:07, Dov Murik wrote:
>> Three trace events had a literal "0x" prefix but the 'len' values were
>> formatted in decimal base.  Keep the prefix and format the numbers as
>> hex, as is usually the case for length of memory regions.
>>
>> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
>> ---
>>   target/i386/trace-events | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/target/i386/trace-events b/target/i386/trace-events
>> index 789c700d4a..65c9b0fdda 100644
>> --- a/target/i386/trace-events
>> +++ b/target/i386/trace-events
>> @@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
>>
>>   # sev.c
>>   kvm_sev_init(void) ""
>> -kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
>> -kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
>> +kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
>> +kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
>>   kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
>>   kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
>> -kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
>> +kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
>>   kvm_sev_launch_measurement(const char *value) "data %s"
>>   kvm_sev_launch_finish(void) ""
>>
> 

Applied to my linux-user-for-6.0 branch.

Thanks,
Laurent
Re: [PATCH] target/i386: tracing: format length values as hex
Posted by Laurent Vivier 3 years, 4 months ago 
Le 13/12/2020 à 16:27, Laurent Vivier a écrit :
> Le 09/12/2020 à 18:58, Dov Murik a écrit :
>> ping
>>
>> Adding CC qemu-trivial.
>>
>> This already got one R-b:
>> https://lists.gnu.org/archive/html/qemu-devel/2020-11/msg00525.html
>>
>> -Dov
>>
>>
>> On 03/11/2020 12:07, Dov Murik wrote:
>>> Three trace events had a literal "0x" prefix but the 'len' values were
>>> formatted in decimal base.  Keep the prefix and format the numbers as
>>> hex, as is usually the case for length of memory regions.
>>>
>>> Signed-off-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
>>> ---
>>>   target/i386/trace-events | 6 +++---
>>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/target/i386/trace-events b/target/i386/trace-events
>>> index 789c700d4a..65c9b0fdda 100644
>>> --- a/target/i386/trace-events
>>> +++ b/target/i386/trace-events
>>> @@ -8,10 +8,10 @@ kvm_x86_update_msi_routes(int num) "Updated %d MSI routes"
>>>
>>>   # sev.c
>>>   kvm_sev_init(void) ""
>>> -kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zu"
>>> -kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zu"
>>> +kvm_memcrypt_register_region(void *addr, size_t len) "addr %p len 0x%zx"
>>> +kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%zx"
>>>   kvm_sev_change_state(const char *old, const char *new) "%s -> %s"
>>>   kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p"
>>> -kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64
>>> +kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIx64
>>>   kvm_sev_launch_measurement(const char *value) "data %s"
>>>   kvm_sev_launch_finish(void) ""
>>>
>>
> 
> Applied to my linux-user-for-6.0 branch.

s/linux-user-for-6.0/trivial-patches/

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.