In commit 5edab03d4040 we added tracepoints to the ps2 keyboard
and mouse emulation. However we didn't remove all the debug-by-printf
support. In fact there is only one printf() remaining, and it is
redundant with the trace_ps2_write_mouse() event next to it.
Remove the printf() and the now-unused DEBUG* macros.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/input/ps2.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index f8746d2f52c..72cdb80ae1c 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -33,12 +33,6 @@
#include "trace.h"
-/* debug PC keyboard */
-//#define DEBUG_KBD
-
-/* debug PC keyboard : only mouse */
-//#define DEBUG_MOUSE
-
/* Keyboard Commands */
#define KBD_CMD_SET_LEDS 0xED /* Set keyboard leds */
#define KBD_CMD_ECHO 0xEE
@@ -790,9 +784,6 @@ void ps2_write_mouse(void *opaque, int val)
PS2MouseState *s = (PS2MouseState *)opaque;
trace_ps2_write_mouse(opaque, val);
-#ifdef DEBUG_MOUSE
- printf("kbd: write mouse 0x%02x\n", val);
-#endif
switch(s->common.write_cmd) {
default:
case -1:
--
2.20.1
On 11/1/20 2:32 PM, Peter Maydell wrote: > In commit 5edab03d4040 we added tracepoints to the ps2 keyboard > and mouse emulation. However we didn't remove all the debug-by-printf > support. In fact there is only one printf() remaining, and it is > redundant with the trace_ps2_write_mouse() event next to it. > Remove the printf() and the now-unused DEBUG* macros. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/input/ps2.c | 9 --------- > 1 file changed, 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Sun, Nov 01, 2020 at 01:32:58PM +0000, Peter Maydell wrote: >In commit 5edab03d4040 we added tracepoints to the ps2 keyboard >and mouse emulation. However we didn't remove all the debug-by-printf >support. In fact there is only one printf() remaining, and it is >redundant with the trace_ps2_write_mouse() event next to it. >Remove the printf() and the now-unused DEBUG* macros. > >Signed-off-by: Peter Maydell <peter.maydell@linaro.org> >--- > hw/input/ps2.c | 9 --------- > 1 file changed, 9 deletions(-) Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
On Sun, 1 Nov 2020 at 13:33, Peter Maydell <peter.maydell@linaro.org> wrote: > > In commit 5edab03d4040 we added tracepoints to the ps2 keyboard > and mouse emulation. However we didn't remove all the debug-by-printf > support. In fact there is only one printf() remaining, and it is > redundant with the trace_ps2_write_mouse() event next to it. > Remove the printf() and the now-unused DEBUG* macros. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org I'll take this via target-arm.next since I'm putting a pullreq together anyway. thanks -- PMM
© 2016 - 2024 Red Hat, Inc.