qdev/qom: Remove explicit type names from error_setg() calls

[PATCH 18/20] filter-dump: Remove unnecessary prefix from error message

Eduardo Habkost posted 20 patches 5 years, 3 months ago

Download mbox

Maintainers: Thomas Huth <thuth@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Markus Armbruster <armbru@redhat.com>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>, Jason Wang <jasowang@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Richard Henderson <rth@twiddle.net>, Halil Pasic <pasic@linux.ibm.com>, David Hildenbrand <david@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, "Michael S. Tsirkin" <mst@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Zhang Chen <chen.zhang@intel.com>

Expand all Fold all

[PATCH 18/20] filter-dump: Remove unnecessary prefix from error message

Posted by Eduardo Habkost 5 years, 3 months ago

object_property_parse() will add a
  "Property '<TYPE>.<PROP>' can't take value '<VALUE>'"
prefix automatically for us.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org
---
 net/dump.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/dump.c b/net/dump.c
index 7fd448d2e1..16c4fa1588 100644
--- a/net/dump.c
+++ b/net/dump.c
@@ -197,8 +197,7 @@ static void filter_dump_set_maxlen(Object *obj, Visitor *v, const char *name,
         return;
     }
     if (value == 0) {
-        error_setg(errp, "Property '%s.%s' doesn't take value '%u'",
-                   object_get_typename(obj), name, value);
+        error_setg(errp, "maxlen can't be zero");
         return;
     }
     nfds->maxlen = value;
-- 
2.28.0