Fix some Neon insns on big-endian hosts

[PATCH 0/2] Fix some Neon insns on big-endian hosts

Peter Maydell posted 2 patches 3 years, 6 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201028191712.4910-1-peter.maydell@linaro.org

Maintainers: Peter Maydell <peter.maydell@linaro.org>

target/arm/vec_helper.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH 0/2] Fix some Neon insns on big-endian hosts

Posted by Peter Maydell 3 years, 6 months ago

This patchseries fixes a couple of places where the vector
helpers we use for Neon insns were missing uses of the
address-swizzling macros H1(), H2() or H4(). This is harmless
on little-endian hosts but causes the wrong results to be
generated on big-endian hosts. The affected insns are
VUDOT(scalar), VSDOT(scalar), VPADD, VPMAX and VPMIN.

This series is independent of Richard's recent "target/arm:
Fix neon reg offsets"; it fixes the handful of remaining
risu test failures I see.

thanks
-- PMM

Peter Maydell (2):
  target/arm: Fix float16 pairwise Neon ops on big-endian hosts
  target/arm: Fix VUDOT/VSDOT (scalar) on big-endian hosts

 target/arm/vec_helper.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.20.1

Re: [PATCH 0/2] Fix some Neon insns on big-endian hosts

Posted by Richard Henderson 3 years, 6 months ago

On 10/28/20 12:17 PM, Peter Maydell wrote:
> Peter Maydell (2):
>   target/arm: Fix float16 pairwise Neon ops on big-endian hosts
>   target/arm: Fix VUDOT/VSDOT (scalar) on big-endian hosts

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~