Fix uninitialized value issues reported by Coverity:
Field 'msg.reserved' is uninitialized when calling write().
Fixes: a5bd05800f8 ("vhost-vdpa: batch updating IOTLB mappings")
Reported-by: Coverity (CID 1432864: UNINIT)
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Cindy Lu <lulu@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/vhost-vdpa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 4f1039910af..01d2101d097 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -90,7 +90,7 @@ static void vhost_vdpa_listener_begin(MemoryListener *listener)
{
struct vhost_vdpa *v = container_of(listener, struct vhost_vdpa, listener);
struct vhost_dev *dev = v->dev;
- struct vhost_msg_v2 msg;
+ struct vhost_msg_v2 msg = {};
int fd = v->device_fd;
if (!(dev->backend_cap & (0x1ULL << VHOST_BACKEND_F_IOTLB_BATCH))) {
@@ -110,7 +110,7 @@ static void vhost_vdpa_listener_commit(MemoryListener *listener)
{
struct vhost_vdpa *v = container_of(listener, struct vhost_vdpa, listener);
struct vhost_dev *dev = v->dev;
- struct vhost_msg_v2 msg;
+ struct vhost_msg_v2 msg = {};
int fd = v->device_fd;
if (!(dev->backend_cap & (0x1ULL << VHOST_BACKEND_F_IOTLB_BATCH))) {
--
2.26.2
On Wed, 28 Oct 2020 at 15:45, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > Fix uninitialized value issues reported by Coverity: > > Field 'msg.reserved' is uninitialized when calling write(). > > Fixes: a5bd05800f8 ("vhost-vdpa: batch updating IOTLB mappings") > Reported-by: Coverity (CID 1432864: UNINIT) > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Hi Philippe; thanks for this patch. I don't suppose you could also write a patch that fixes the same problem in vhost_kernel_send_device_iotlb_msg() (CID 1432871) ? thanks -- PMM
On 11/2/20 6:31 PM, Peter Maydell wrote: > On Wed, 28 Oct 2020 at 15:45, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> >> Fix uninitialized value issues reported by Coverity: >> >> Field 'msg.reserved' is uninitialized when calling write(). >> >> Fixes: a5bd05800f8 ("vhost-vdpa: batch updating IOTLB mappings") >> Reported-by: Coverity (CID 1432864: UNINIT) >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > > Hi Philippe; thanks for this patch. I don't suppose you > could also write a patch that fixes the same problem in > vhost_kernel_send_device_iotlb_msg() (CID 1432871) ? Oh I hadn't noticed it, sure, no problem!
© 2016 - 2024 Red Hat, Inc.