[v2] s390x: pv: Diag318 fixes

[PATCH v2 0/2] s390x: pv: Diag318 fixes

Janosch Frank posted 2 patches 3 years, 6 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201022103135.126033-1-frankja@linux.ibm.com

Maintainers: Cornelia Huck <cohuck@redhat.com>, David Hildenbrand <david@redhat.com>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Christian Borntraeger <borntraeger@de.ibm.com>, Halil Pasic <pasic@linux.ibm.com>

hw/s390x/sclp.c             | 5 -----
target/s390x/cpu_features.c | 5 +++++
target/s390x/cpu_features.h | 4 ++++
target/s390x/cpu_models.c   | 4 ++++
target/s390x/kvm.c          | 3 +--
5 files changed, 14 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH v2 0/2] s390x: pv: Diag318 fixes

Posted by Janosch Frank 3 years, 6 months ago

Here are two fixes for the diag318 support that fix crashes when
booting PV guests.

We're working on extending our testing to catch problems like these
earlier.


Branch:
https://gitlab.com/frankja/qemu/-/commits/bb/frankja/diag318_fixes

CI:
https://gitlab.com/frankja/qemu/-/pipelines/206174979


V2:
	* Moved fencing nto cpu model functions
	* Added rev-by and acks


Janosch Frank (2):
  s390x: pv: Remove sclp boundary checks
  s390x: pv: Fix diag318 PV fencing

 hw/s390x/sclp.c             | 5 -----
 target/s390x/cpu_features.c | 5 +++++
 target/s390x/cpu_features.h | 4 ++++
 target/s390x/cpu_models.c   | 4 ++++
 target/s390x/kvm.c          | 3 +--
 5 files changed, 14 insertions(+), 7 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/2] s390x: pv: Diag318 fixes

Posted by Cornelia Huck 3 years, 6 months ago

On Thu, 22 Oct 2020 06:31:33 -0400
Janosch Frank <frankja@linux.ibm.com> wrote:

> Here are two fixes for the diag318 support that fix crashes when
> booting PV guests.
> 
> We're working on extending our testing to catch problems like these
> earlier.
> 
> 
> Branch:
> https://gitlab.com/frankja/qemu/-/commits/bb/frankja/diag318_fixes
> 
> CI:
> https://gitlab.com/frankja/qemu/-/pipelines/206174979
> 
> 
> V2:
> 	* Moved fencing nto cpu model functions
> 	* Added rev-by and acks
> 
> 
> Janosch Frank (2):
>   s390x: pv: Remove sclp boundary checks
>   s390x: pv: Fix diag318 PV fencing
> 
>  hw/s390x/sclp.c             | 5 -----
>  target/s390x/cpu_features.c | 5 +++++
>  target/s390x/cpu_features.h | 4 ++++
>  target/s390x/cpu_models.c   | 4 ++++
>  target/s390x/kvm.c          | 3 +--
>  5 files changed, 14 insertions(+), 7 deletions(-)
> 

Thanks, applied.

Re: [PATCH v2 0/2] s390x: pv: Diag318 fixes

Posted by Collin Walling 3 years, 6 months ago

On 10/22/20 6:31 AM, Janosch Frank wrote:
> Here are two fixes for the diag318 support that fix crashes when
> booting PV guests.
> 
> We're working on extending our testing to catch problems like these
> earlier.
> 
> 
> Branch:
> https://gitlab.com/frankja/qemu/-/commits/bb/frankja/diag318_fixes
> 
> CI:
> https://gitlab.com/frankja/qemu/-/pipelines/206174979
> 
> 
> V2:
> 	* Moved fencing nto cpu model functions
> 	* Added rev-by and acks
> 
> 
> Janosch Frank (2):
>   s390x: pv: Remove sclp boundary checks
>   s390x: pv: Fix diag318 PV fencing
> 
>  hw/s390x/sclp.c             | 5 -----
>  target/s390x/cpu_features.c | 5 +++++
>  target/s390x/cpu_features.h | 4 ++++
>  target/s390x/cpu_models.c   | 4 ++++
>  target/s390x/kvm.c          | 3 +--
>  5 files changed, 14 insertions(+), 7 deletions(-)
> 

Thanks for correcting this. You've certainly received plenty of reviews
and ack's, but since this touches code I worked on:

Reviewed-by: Collin Walling <walling@linux.ibm.com>

-- 
Regards,
Collin

Stay safe and stay healthy