ide: fix SRST (again)

[PATCH 0/3] ide: fix SRST (again)

John Snow posted 3 patches 3 years, 6 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201020200242.1497705-1-jsnow@redhat.com

Maintainers: John Snow <jsnow@redhat.com>

hw/ide/core.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH 0/3] ide: fix SRST (again)

Posted by John Snow 3 years, 6 months ago

My last fix for SRST wasn't entirely correct and caused a regression;
namely we need to mime execution of the diagnostic command. If we don't,
Linux bins the IDE device as 'horked'.

For detailed reading on the SRST protocol, I recommend checking out the
ATA8-APT specification.

John Snow (3):
  ide: run diagnostic after SRST
  ide: perform SRST as early as possible
  ide: clear SRST after SRST finishes

 hw/ide/core.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

-- 
2.26.2

Re: [PATCH 0/3] ide: fix SRST (again)

Posted by Mark Cave-Ayland 3 years, 6 months ago

On 20/10/2020 21:02, John Snow wrote:

> My last fix for SRST wasn't entirely correct and caused a regression;
> namely we need to mime execution of the diagnostic command. If we don't,
> Linux bins the IDE device as 'horked'.
> 
> For detailed reading on the SRST protocol, I recommend checking out the
> ATA8-APT specification.
> 
> John Snow (3):
>    ide: run diagnostic after SRST
>    ide: perform SRST as early as possible
>    ide: clear SRST after SRST finishes
> 
>   hw/ide/core.c | 12 +++++-------
>   1 file changed, 5 insertions(+), 7 deletions(-)

I tried this in 3 combinations: HD only, HD + CD, and CD only and I didn't notice any 
error messages during my boot tests on qemu-system-sparc64 so:

Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.