hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

[PATCH] [RFC] hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

Zenghui Yu posted 1 patch 3 years, 6 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201019091508.197-1-yuzenghui@huawei.com

Maintainers: Eric Auger <eric.auger@redhat.com>, Peter Maydell <peter.maydell@linaro.org>

hw/arm/smmuv3.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] [RFC] hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

Posted by Zenghui Yu 3 years, 6 months ago

Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA
translation can work properly during migration.

Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---

not sure if anything would actually go wrong...

 hw/arm/smmuv3.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index 0122700e72..2017ba7a5a 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -1440,6 +1440,7 @@ static const VMStateDescription vmstate_smmuv3 = {
     .name = "smmuv3",
     .version_id = 1,
     .minimum_version_id = 1,
+    .priority = MIG_PRI_IOMMU,
     .fields = (VMStateField[]) {
         VMSTATE_UINT32(features, SMMUv3State),
         VMSTATE_UINT8(sid_size, SMMUv3State),
-- 
2.19.1

Re: [PATCH] [RFC] hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

Posted by Auger Eric 3 years, 6 months ago

Hi Zenghui,

On 10/19/20 11:15 AM, Zenghui Yu wrote:
> Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA
> translation can work properly during migration.

Sorry I missed this patch. good catch!

Acked-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric

> 
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> 
> not sure if anything would actually go wrong...
> 
>  hw/arm/smmuv3.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index 0122700e72..2017ba7a5a 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -1440,6 +1440,7 @@ static const VMStateDescription vmstate_smmuv3 = {
>      .name = "smmuv3",
>      .version_id = 1,
>      .minimum_version_id = 1,
> +    .priority = MIG_PRI_IOMMU,
>      .fields = (VMStateField[]) {
>          VMSTATE_UINT32(features, SMMUv3State),
>          VMSTATE_UINT8(sid_size, SMMUv3State),
>

Re: [PATCH] [RFC] hw/arm/smmuv3: Set the restoration priority of the vSMMUv3 explicitly

Posted by Peter Maydell 3 years, 6 months ago

On Mon, 26 Oct 2020 at 17:03, Auger Eric <eric.auger@redhat.com> wrote:
>
> Hi Zenghui,
>
> On 10/19/20 11:15 AM, Zenghui Yu wrote:
> > Ensure the vSMMUv3 will be restored before all PCIe devices so that DMA
> > translation can work properly during migration.
>
> Sorry I missed this patch. good catch!
>
> Acked-by: Eric Auger <eric.auger@redhat.com>



Applied to target-arm.next, thanks.

-- PMM