[v2] hw/rtc/m48t59: Simplify m48t59_init()

[PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

Philippe Mathieu-Daudé posted 2 patches 3 years, 6 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201015194647.477252-1-f4bug@amsat.org

include/hw/rtc/m48t59.h |  5 ++---
hw/ppc/ppc405_boards.c  |  2 +-
hw/rtc/m48t59.c         | 14 +++-----------
hw/sparc/sun4m.c        |  3 ++-
hw/sparc64/sun4u.c      |  7 ++-----
5 files changed, 10 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

Posted by Philippe Mathieu-Daudé 3 years, 6 months ago

Since v1:
- Do not remove mem_base in patch 1 (Laurent)
- Pass MemoryRegion* (new patch)
- Run check-qtest

Philippe Mathieu-Daudé (2):
  hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument
  hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument

 include/hw/rtc/m48t59.h |  5 ++---
 hw/ppc/ppc405_boards.c  |  2 +-
 hw/rtc/m48t59.c         | 14 +++-----------
 hw/sparc/sun4m.c        |  3 ++-
 hw/sparc64/sun4u.c      |  7 ++-----
 5 files changed, 10 insertions(+), 21 deletions(-)

-- 
2.26.2

Re: [PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

Posted by Mark Cave-Ayland 3 years, 6 months ago

On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote:

> Since v1:
> - Do not remove mem_base in patch 1 (Laurent)
> - Pass MemoryRegion* (new patch)
> - Run check-qtest
> 
> Philippe Mathieu-Daudé (2):
>    hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument
>    hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument
> 
>   include/hw/rtc/m48t59.h |  5 ++---
>   hw/ppc/ppc405_boards.c  |  2 +-
>   hw/rtc/m48t59.c         | 14 +++-----------
>   hw/sparc/sun4m.c        |  3 ++-
>   hw/sparc64/sun4u.c      |  7 ++-----
>   5 files changed, 10 insertions(+), 21 deletions(-)

This looks good, and from what you've done here it's only a little more work to 
remove m48t59_init() completely. Would you mind if I try this using these patches as 
a starting point? :)


ATB,

Mark.

Re: [PATCH v2 0/2] hw/rtc/m48t59: Simplify m48t59_init()

Posted by Philippe Mathieu-Daudé 3 years, 6 months ago

Le ven. 16 oct. 2020 11:39, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
a écrit :

> On 15/10/2020 20:46, Philippe Mathieu-Daudé wrote:
>
> > Since v1:
> > - Do not remove mem_base in patch 1 (Laurent)
> > - Pass MemoryRegion* (new patch)
> > - Run check-qtest
> >
> > Philippe Mathieu-Daudé (2):
> >    hw/rtc/m48t59: Simplify m48t59_init() removing 'io_base' argument
> >    hw/rtc/m48t59: Simplify m48t59_init() passing MemoryRegion argument
> >
> >   include/hw/rtc/m48t59.h |  5 ++---
> >   hw/ppc/ppc405_boards.c  |  2 +-
> >   hw/rtc/m48t59.c         | 14 +++-----------
> >   hw/sparc/sun4m.c        |  3 ++-
> >   hw/sparc64/sun4u.c      |  7 ++-----
> >   5 files changed, 10 insertions(+), 21 deletions(-)
>
> This looks good, and from what you've done here it's only a little more
> work to
> remove m48t59_init() completely. Would you mind if I try this using these
> patches as
> a starting point? :)
>

I had a look at your previous suggestion, but I have too many in flight
series waiting for 5.2, so sure go ahead!


>
> ATB,
>
> Mark.
>
>