[v1] configure: fix handling of --docdir parameter

[PATCH] configure: fix handling of --docdir parameter

Bruce Rogers posted 1 patch 3 years, 6 months ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201015190742.270629-1-brogers@suse.com

configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] configure: fix handling of --docdir parameter

Posted by Bruce Rogers 3 years, 6 months ago

Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the
qemu_docdir name in the final assignment. Unfortunately, one instance of
qemu_docdir was missed: the one which comes from the --docdir parameter.
This patch restores the proper handling of the --docdir parameter.

Fixes: ca8c0909f01 ("configure: build docdir like other suffixed
directories")

Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index f839c2a557..07acd01a25 100755
--- a/configure
+++ b/configure
@@ -971,7 +971,7 @@ for opt do
   ;;
   --with-suffix=*) qemu_suffix="$optarg"
   ;;
-  --docdir=*) qemu_docdir="$optarg"
+  --docdir=*) docdir="$optarg"
   ;;
   --sysconfdir=*) sysconfdir="$optarg"
   ;;
-- 
2.28.0

Re: [PATCH] configure: fix handling of --docdir parameter

Posted by Philippe Mathieu-Daudé 3 years, 6 months ago

On 10/15/20 9:07 PM, Bruce Rogers wrote:
> Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses the
> qemu_docdir name in the final assignment. Unfortunately, one instance of
> qemu_docdir was missed: the one which comes from the --docdir parameter.
> This patch restores the proper handling of the --docdir parameter.
> 
> Fixes: ca8c0909f01 ("configure: build docdir like other suffixed
> directories")
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>