[PATCH v3 0/3] tcg-cpus: split into 3 tcg variants

Claudio Fontana posted 3 patches 3 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201015143217.29337-1-cfontana@suse.de
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
accel/tcg/meson.build       |   9 +-
accel/tcg/tcg-all.c         |  13 +-
accel/tcg/tcg-cpus-icount.c | 147 +++++++++++
accel/tcg/tcg-cpus-icount.h |  17 ++
accel/tcg/tcg-cpus-mttcg.c  | 140 ++++++++++
accel/tcg/tcg-cpus-rr.c     | 305 ++++++++++++++++++++++
accel/tcg/tcg-cpus-rr.h     |  21 ++
accel/tcg/tcg-cpus.c        | 504 +-----------------------------------
accel/tcg/tcg-cpus.h        |  12 +-
softmmu/icount.c            |   2 +-
10 files changed, 669 insertions(+), 501 deletions(-)
create mode 100644 accel/tcg/tcg-cpus-icount.c
create mode 100644 accel/tcg/tcg-cpus-icount.h
create mode 100644 accel/tcg/tcg-cpus-mttcg.c
create mode 100644 accel/tcg/tcg-cpus-rr.c
create mode 100644 accel/tcg/tcg-cpus-rr.h
[PATCH v3 0/3] tcg-cpus: split into 3 tcg variants
Posted by Claudio Fontana 3 years, 6 months ago
The purpose of this series is to split the tcg-cpus into
3 variants:

tcg_cpus_mttcg    (multithreaded tcg vcpus)
tcg_cpus_rr       (single threaded round robin vcpus)
tcg_cpus_icount   (same as RR, but using icount)

Ciao,

Claudio

v2 -> v3:

* comments: remove some, replace "vcpu" with "vCPU" (Philippe)
* tcg_cpus_mttcg.h: remove include completely after the last export is gone.
  (Richard)

v1 -> v2:

* fixed file preambles to be clearer (Philippe)
* reworked includes (Philippe)

* made a few symbols static, as they are private now.
* added a rename patch at the end to make naming more consistent.

* added Suggested-by: Richard, since it is his idea originally.

Claudio Fontana (3):
  accel/tcg: split CpusAccel into three TCG variants
  accel/tcg: split tcg_start_vcpu_thread
  accel/tcg: rename tcg-cpus functions to match module name

 accel/tcg/meson.build       |   9 +-
 accel/tcg/tcg-all.c         |  13 +-
 accel/tcg/tcg-cpus-icount.c | 147 +++++++++++
 accel/tcg/tcg-cpus-icount.h |  17 ++
 accel/tcg/tcg-cpus-mttcg.c  | 140 ++++++++++
 accel/tcg/tcg-cpus-rr.c     | 305 ++++++++++++++++++++++
 accel/tcg/tcg-cpus-rr.h     |  21 ++
 accel/tcg/tcg-cpus.c        | 504 +-----------------------------------
 accel/tcg/tcg-cpus.h        |  12 +-
 softmmu/icount.c            |   2 +-
 10 files changed, 669 insertions(+), 501 deletions(-)
 create mode 100644 accel/tcg/tcg-cpus-icount.c
 create mode 100644 accel/tcg/tcg-cpus-icount.h
 create mode 100644 accel/tcg/tcg-cpus-mttcg.c
 create mode 100644 accel/tcg/tcg-cpus-rr.c
 create mode 100644 accel/tcg/tcg-cpus-rr.h

-- 
2.26.2


Re: [PATCH v3 0/3] tcg-cpus: split into 3 tcg variants
Posted by Richard Henderson 3 years, 6 months ago
On 10/15/20 7:32 AM, Claudio Fontana wrote:
> Claudio Fontana (3):
>   accel/tcg: split CpusAccel into three TCG variants
>   accel/tcg: split tcg_start_vcpu_thread
>   accel/tcg: rename tcg-cpus functions to match module name

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


Re: [PATCH v3 0/3] tcg-cpus: split into 3 tcg variants
Posted by Claudio Fontana 3 years, 5 months ago
On 10/19/20 5:00 PM, Richard Henderson wrote:
> On 10/15/20 7:32 AM, Claudio Fontana wrote:
>> Claudio Fontana (3):
>>   accel/tcg: split CpusAccel into three TCG variants
>>   accel/tcg: split tcg_start_vcpu_thread
>>   accel/tcg: rename tcg-cpus functions to match module name
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> r~
> 
> 

Hi all, just pinging about the status of this series, is it already in someone's queue?

Otherwise it's fine of course to delay it if there are concerns about tightening up the upcoming release.

Thanks,

Claudio

Re: [PATCH v3 0/3] tcg-cpus: split into 3 tcg variants
Posted by Richard Henderson 3 years, 5 months ago
On 11/9/20 8:02 AM, Claudio Fontana wrote:
> On 10/19/20 5:00 PM, Richard Henderson wrote:
>> On 10/15/20 7:32 AM, Claudio Fontana wrote:
>>> Claudio Fontana (3):
>>>   accel/tcg: split CpusAccel into three TCG variants
>>>   accel/tcg: split tcg_start_vcpu_thread
>>>   accel/tcg: rename tcg-cpus functions to match module name
>>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>>
>> r~
>>
>>
> 
> Hi all, just pinging about the status of this series, is it already in someone's queue?
> 
> Otherwise it's fine of course to delay it if there are concerns about tightening up the upcoming release.

Oof da.  It has been a month.  Since Paolo picked up the first part, I assumed
he'd get the second too.

Since it's not critical, I'll queue it for 6.0.
But at least it'll be queued somewhere...


r~