hw/arm/strongarm: Fix 'time to transmit a char' unit comment

[PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment

Philippe Mathieu-Daudé posted 1 patch 3 years, 7 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201014213601.205222-1-f4bug@amsat.org

hw/arm/strongarm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

The time to transmit a char is expressed in nanoseconds, not in ticks.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/arm/strongarm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c
index d7133eea6f9..ca7c385f313 100644
--- a/hw/arm/strongarm.c
+++ b/hw/arm/strongarm.c
@@ -935,7 +935,7 @@ struct StrongARMUARTState {
     uint8_t rx_start;
     uint8_t rx_len;
 
-    uint64_t char_transmit_time; /* time to transmit a char in ticks*/
+    uint64_t char_transmit_time; /* time to transmit a char in nanoseconds */
     bool wait_break_end;
     QEMUTimer *rx_timeout_timer;
     QEMUTimer *tx_timer;
-- 
2.26.2

Re: [PATCH] hw/arm/strongarm: Fix 'time to transmit a char' unit comment

Posted by Peter Maydell 3 years, 6 months ago

On Wed, 14 Oct 2020 at 22:36, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The time to transmit a char is expressed in nanoseconds, not in ticks.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/arm/strongarm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm.c
> index d7133eea6f9..ca7c385f313 100644
> --- a/hw/arm/strongarm.c
> +++ b/hw/arm/strongarm.c
> @@ -935,7 +935,7 @@ struct StrongARMUARTState {
>      uint8_t rx_start;
>      uint8_t rx_len;
>
> -    uint64_t char_transmit_time; /* time to transmit a char in ticks*/
> +    uint64_t char_transmit_time; /* time to transmit a char in nanoseconds */
>      bool wait_break_end;
>      QEMUTimer *rx_timeout_timer;
>      QEMUTimer *tx_timer;



Applied to target-arm.next, thanks.

-- PMM