[PATCH 2/7] make: run shell with pipefail

Paolo Bonzini posted 7 patches 5 years, 2 months ago
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Fam Zheng <fam@euphon.net>, Ed Maste <emaste@freebsd.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Li-Wen Hsu <lwhsu@freebsd.org>, Cleber Rosa <crosa@redhat.com>
[PATCH 2/7] make: run shell with pipefail
Posted by Paolo Bonzini 5 years, 2 months ago
Without pipefail, it is possible to miss failures if the recipes
include pipes.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Makefile b/Makefile
index c37e513431..5e51e61c3b 100644
--- a/Makefile
+++ b/Makefile
@@ -14,6 +14,8 @@ SRC_PATH=.
 # we have explicit rules for everything
 MAKEFLAGS += -rR
 
+SHELL = /usr/bin/env bash -o pipefail
+
 # Usage: $(call quiet-command,command and args,"NAME","args to print")
 # This will run "command and args", and either:
 #  if V=1 just print the whole command and args
-- 
2.26.2



Re: [PATCH 2/7] make: run shell with pipefail
Posted by Daniel P. Berrangé 5 years, 2 months ago
On Wed, Oct 14, 2020 at 09:54:11AM -0400, Paolo Bonzini wrote:
> Without pipefail, it is possible to miss failures if the recipes
> include pipes.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|