[v1] Trivial branch for 5.2 patches

[PULL 00/15] Trivial branch for 5.2 patches

Posted by Laurent Vivier 3 years, 6 months ago

The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int=
o staging (2020-10-12 11:29:42 +0100)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request

for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c:

  meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200)

----------------------------------------------------------------
Trivial Patches Pull request 20201013

----------------------------------------------------------------

Christian Borntraeger (1):
  vmdk: fix maybe uninitialized warnings

Elena Afanasova (1):
  block/blkdebug: fix memory leak

Greg Kurz (1):
  hw/acpi/piix4: Rename piix4_pm_add_propeties() to
    piix4_pm_add_properties()

Julia Suvorova (1):
  hw/pci: Fix typo in PCI hot-plug error message

Laurent Vivier (2):
  hw/char/serial: remove duplicate .class_init in serial_mm_info
  goldfish_rtc: change MemoryRegionOps endianness to
    DEVICE_NATIVE_ENDIAN

Marc-Andr=C3=A9 Lureau (1):
  mingw: fix error __USE_MINGW_ANSI_STDIO redefined

Markus Armbruster (2):
  qemu-img-cmds.hx: Update comment that mentions Texinfo
  target/i386/cpu: Update comment that mentions Texinfo

Philippe Mathieu-Daud=C3=A9 (3):
  hw/block/nvme: Simplify timestamp sum
  softmmu/memory: Log invalid memory accesses
  target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

Sergei Trofimovich (1):
  meson.build: drop duplicate 'sparc64' entry

Thomas Huth (2):
  hw/rtc/twl92230: Silence warnings about missing fallthrough statements
  tests/test-char: Use a proper fallthrough comment

 block/blkdebug.c            |  1 +
 block/vmdk.c                |  8 +++---
 hw/acpi/piix4.c             |  4 +--
 hw/block/nvme.c             |  7 +-----
 hw/char/serial.c            |  1 -
 hw/pci/pci.c                |  2 +-
 hw/ppc/spapr_pci.c          |  2 +-
 hw/rtc/goldfish_rtc.c       |  2 +-
 hw/rtc/twl92230.c           | 50 ++++++++++++++++++-------------------
 meson.build                 |  2 +-
 migration/dirtyrate.c       |  3 ++-
 qemu-img-cmds.hx            |  2 +-
 softmmu/memory.c            | 16 ++++++++++++
 target/i386/cpu.c           |  3 ++-
 target/sparc/int32_helper.c |  1 -
 tests/test-bitmap.c         |  1 -
 tests/test-char.c           |  2 +-
 17 files changed, 58 insertions(+), 49 deletions(-)

--=20
2.26.2

Re: [PULL 00/15] Trivial branch for 5.2 patches

Posted by Peter Maydell 3 years, 6 months ago

On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int=
> o staging (2020-10-12 11:29:42 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request
>
> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c:
>
>   meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200)
>
> ----------------------------------------------------------------
> Trivial Patches Pull request 20201013
>
> ----------------------------------------------------------------

Compile failure on ppc64be:

../../hw/rtc/twl92230.c: In function ‘menelaus_rx’:
../../hw/rtc/twl92230.c:289:23: error: array subscript is above array
bounds [-Werror=array-bounds]
         return s->dcdc[addr - MENELAUS_VCORE_CTRL1];
                       ^
cc1: all warnings being treated as errors

thanks
-- PMM

Re: [PULL 00/15] Trivial branch for 5.2 patches

Posted by Thomas Huth 3 years, 6 months ago

On 13/10/2020 13.06, Peter Maydell wrote:
> On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:
>>
>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int=
>> o staging (2020-10-12 11:29:42 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request
>>
>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c:
>>
>>   meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200)
>>
>> ----------------------------------------------------------------
>> Trivial Patches Pull request 20201013
>>
>> ----------------------------------------------------------------
> 
> Compile failure on ppc64be:
> 
> ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’:
> ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array
> bounds [-Werror=array-bounds]
>          return s->dcdc[addr - MENELAUS_VCORE_CTRL1];

Uh, oh, mea culpa, copy-n-paste error... that should have been
MENELAUS_DCDC_CTRL1 instead.
Laurent, could you fix it up, or shall I send a v2 of the patch?

 Thomas

Re: [PULL 00/15] Trivial branch for 5.2 patches

Posted by Laurent Vivier 3 years, 6 months ago

Le 13/10/2020 à 13:34, Thomas Huth a écrit :
> On 13/10/2020 13.06, Peter Maydell wrote:
>> On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote:
>>>
>>> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:
>>>
>>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int=
>>> o staging (2020-10-12 11:29:42 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request
>>>
>>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c:
>>>
>>>   meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200)
>>>
>>> ----------------------------------------------------------------
>>> Trivial Patches Pull request 20201013
>>>
>>> ----------------------------------------------------------------
>>
>> Compile failure on ppc64be:
>>
>> ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’:
>> ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array
>> bounds [-Werror=array-bounds]
>>          return s->dcdc[addr - MENELAUS_VCORE_CTRL1];
> 
> Uh, oh, mea culpa, copy-n-paste error... that should have been
> MENELAUS_DCDC_CTRL1 instead.
> Laurent, could you fix it up, or shall I send a v2 of the patch?

I prefere a v2, I don't like to play with patches in a pull request.

Thanks,
Laurent

Re: [PULL 00/15] Trivial branch for 5.2 patches

Posted by Thomas Huth 3 years, 6 months ago

On 13/10/2020 13.40, Laurent Vivier wrote:
> Le 13/10/2020 à 13:34, Thomas Huth a écrit :
>> On 13/10/2020 13.06, Peter Maydell wrote:
>>> On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote:
>>>>
>>>> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:
>>>>
>>>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int=
>>>> o staging (2020-10-12 11:29:42 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request
>>>>
>>>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c:
>>>>
>>>>   meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200)
>>>>
>>>> ----------------------------------------------------------------
>>>> Trivial Patches Pull request 20201013
>>>>
>>>> ----------------------------------------------------------------
>>>
>>> Compile failure on ppc64be:
>>>
>>> ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’:
>>> ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array
>>> bounds [-Werror=array-bounds]
>>>          return s->dcdc[addr - MENELAUS_VCORE_CTRL1];
>>
>> Uh, oh, mea culpa, copy-n-paste error... that should have been
>> MENELAUS_DCDC_CTRL1 instead.
>> Laurent, could you fix it up, or shall I send a v2 of the patch?
> 
> I prefere a v2, I don't like to play with patches in a pull request.

Sure, I'll send a v2 when I've got some spare time (i.e. for a future pull
request, not for this one).

 Thomas

Re: [PULL 00/15] Trivial branch for 5.2 patches

Posted by Laurent Vivier 3 years, 6 months ago

Le 13/10/2020 à 13:06, Peter Maydell a écrit :
> On Tue, 13 Oct 2020 at 07:56, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> The following changes since commit 2387df497b4b4bcf754eb7398edca82889e2ef54:
>>
>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-10-10' int=
>> o staging (2020-10-12 11:29:42 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/vivier/qemu.git tags/trivial-branch-for-5.2-pull-request
>>
>> for you to fetch changes up to ef3a1d9fc36140f8933fbced70ee21fd9740b33c:
>>
>>   meson.build: drop duplicate 'sparc64' entry (2020-10-12 23:11:32 +0200)
>>
>> ----------------------------------------------------------------
>> Trivial Patches Pull request 20201013
>>
>> ----------------------------------------------------------------
> 
> Compile failure on ppc64be:
> 
> ../../hw/rtc/twl92230.c: In function ‘menelaus_rx’:
> ../../hw/rtc/twl92230.c:289:23: error: array subscript is above array
> bounds [-Werror=array-bounds]
>          return s->dcdc[addr - MENELAUS_VCORE_CTRL1];
>                        ^
> cc1: all warnings being treated as errors

Thank you.

I'm removing the following patch patch from the pull request:

  hw/rtc/twl92230: Silence warnings about missing fallthrough statements

Thanks,
Laurent