1. Patchew
  2. QEMU
  3. [PATCH v7 0/4] Improve cirrus msys2
  4. View patch

[PATCH v7 2/4] gitignore: ignore a bit more

Yonggang Luo posted 4 patches 5 years, 3 months ago
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Markus Armbruster <armbru@redhat.com>, Cleber Rosa <crosa@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Li-Wen Hsu <lwhsu@freebsd.org>, Ed Maste <emaste@freebsd.org>, Peter Maydell <peter.maydell@linaro.org>
[PATCH v7 2/4] gitignore: ignore a bit more
Posted by Yonggang Luo 5 years, 3 months ago 
Enable the creating multiple build directory at the source root.
Ignore /meson/ and /roms/ for better search experience.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
 .gitignore | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.gitignore b/.gitignore
index b32bca1315..f78ee9f297 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,5 @@
 /GNUmakefile
-/build/
+/build*/
 *.pyc
 .sdk
 .stgit-*
@@ -10,3 +10,5 @@ TAGS
 *~
 *.ast_raw
 *.depend_raw
+/meson/
+/roms/**/*
-- 
2.28.0.windows.1
Re: [PATCH v7 2/4] gitignore: ignore a bit more
Posted by Philippe Mathieu-Daudé 5 years, 3 months ago 
On 10/13/20 1:37 AM, Yonggang Luo wrote:
> Enable the creating multiple build directory at the source root.
> Ignore /meson/ and /roms/ for better search experience.
> 
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
>   .gitignore | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitignore b/.gitignore
> index b32bca1315..f78ee9f297 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,5 +1,5 @@
>   /GNUmakefile
> -/build/
> +/build*/
>   *.pyc
>   .sdk
>   .stgit-*
> @@ -10,3 +10,5 @@ TAGS
>   *~
>   *.ast_raw
>   *.depend_raw
> +/meson/
> +/roms/**/*

Why?
Re: [PATCH v7 2/4] gitignore: ignore a bit more
Posted by 罗勇刚 (Yonggang Luo) 5 years, 3 months ago 
On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
>
> On 10/13/20 1:37 AM, Yonggang Luo wrote:
> > Enable the creating multiple build directory at the source root.
> > Ignore /meson/ and /roms/ for better search experience.
> >
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> >   .gitignore | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/.gitignore b/.gitignore
> > index b32bca1315..f78ee9f297 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -1,5 +1,5 @@
> >   /GNUmakefile
> > -/build/
> > +/build*/
> >   *.pyc
> >   .sdk
> >   .stgit-*
> > @@ -10,3 +10,5 @@ TAGS
> >   *~
> >   *.ast_raw
> >   *.depend_raw
> > +/meson/
> > +/roms/**/*
>
> Why?
As I said, help for searching tool ignore it, meson and roms are thirdparty
packages.
>


--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo
Re: [PATCH v7 2/4] gitignore: ignore a bit more
Posted by Thomas Huth 5 years, 3 months ago 
On 13/10/2020 10.53, 罗勇刚(Yonggang Luo) wrote:
> 
> 
> On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé <philmd@redhat.com
> <mailto:philmd@redhat.com>> wrote:
>>
>> On 10/13/20 1:37 AM, Yonggang Luo wrote:
>> > Enable the creating multiple build directory at the source root.
>> > Ignore /meson/ and /roms/ for better search experience.
>> >
>> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com
> <mailto:luoyonggang@gmail.com>>
>> > ---
>> >   .gitignore | 4 +++-
>> >   1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/.gitignore b/.gitignore
>> > index b32bca1315..f78ee9f297 100644
>> > --- a/.gitignore
>> > +++ b/.gitignore
>> > @@ -1,5 +1,5 @@
>> >   /GNUmakefile
>> > -/build/
>> > +/build*/

The naming of your private build directories is IMHO something that should
not be part of the public .gitignore file. I think you can use your
~/.gitignore file for that.

>> >   *.pyc
>> >   .sdk
>> >   .stgit-*
>> > @@ -10,3 +10,5 @@ TAGS
>> >   *~
>> >   *.ast_raw
>> >   *.depend_raw
>> > +/meson/
>> > +/roms/**/*
>>
>> Why?
> As I said, help for searching tool ignore it, meson and roms are thirdparty
> packages.

Hmm, but "git status" should still show whether there are modifications in
the subdirectories, so IMHO this should not be ignored?

 Thomas
Re: [PATCH v7 2/4] gitignore: ignore a bit more
Posted by 罗勇刚 (Yonggang Luo) 5 years, 3 months ago 
On Tue, Oct 13, 2020 at 5:02 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 13/10/2020 10.53, 罗勇刚(Yonggang Luo) wrote:
> >
> >
> > On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé <
philmd@redhat.com
> > <mailto:philmd@redhat.com>> wrote:
> >>
> >> On 10/13/20 1:37 AM, Yonggang Luo wrote:
> >> > Enable the creating multiple build directory at the source root.
> >> > Ignore /meson/ and /roms/ for better search experience.
> >> >
> >> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com
> > <mailto:luoyonggang@gmail.com>>
> >> > ---
> >> >   .gitignore | 4 +++-
> >> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >> >
> >> > diff --git a/.gitignore b/.gitignore
> >> > index b32bca1315..f78ee9f297 100644
> >> > --- a/.gitignore
> >> > +++ b/.gitignore
> >> > @@ -1,5 +1,5 @@
> >> >   /GNUmakefile
> >> > -/build/
> >> > +/build*/
>
> The naming of your private build directories is IMHO something that should
> not be part of the public .gitignore file. I think you can use your
> ~/.gitignore file for that.
>
> >> >   *.pyc
> >> >   .sdk
> >> >   .stgit-*
> >> > @@ -10,3 +10,5 @@ TAGS
> >> >   *~
> >> >   *.ast_raw
> >> >   *.depend_raw
> >> > +/meson/
> >> > +/roms/**/*
> >>
> >> Why?
> > As I said, help for searching tool ignore it, meson and roms are
thirdparty
> > packages.
>
> Hmm, but "git status" should still show whether there are modifications in
> the subdirectories, so IMHO this should not be ignored?
Yeap, it's doens't affect git, just affect search tools. If this is
improper, skip it, I can use it locally
>
>  Thomas
>


--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.