target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

[PATCH] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

Posted by Philippe Mathieu-Daudé 3 years, 6 months ago

Commit 0b09be2b2f ("Nicer debug output for exceptions") added
twice the same "Tag Overflow" entry, remove the extra one.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/sparc/int32_helper.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c
index 9a71e1abd87..ba63c739c1e 100644
--- a/target/sparc/int32_helper.c
+++ b/target/sparc/int32_helper.c
@@ -50,7 +50,6 @@ static const char * const excp_names[0x80] = {
     [TT_EXTINT | 0xd] = "External Interrupt 13",
     [TT_EXTINT | 0xe] = "External Interrupt 14",
     [TT_EXTINT | 0xf] = "External Interrupt 15",
-    [TT_TOVF] = "Tag Overflow",
     [TT_CODE_ACCESS] = "Instruction Access Error",
     [TT_DATA_ACCESS] = "Data Access Error",
     [TT_DIV_ZERO] = "Division By Zero",
-- 
2.26.2

Re: [PATCH] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

Posted by Mark Cave-Ayland 3 years, 6 months ago

On 11/10/2020 21:01, Philippe Mathieu-Daudé wrote:

> Commit 0b09be2b2f ("Nicer debug output for exceptions") added
> twice the same "Tag Overflow" entry, remove the extra one.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/sparc/int32_helper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c
> index 9a71e1abd87..ba63c739c1e 100644
> --- a/target/sparc/int32_helper.c
> +++ b/target/sparc/int32_helper.c
> @@ -50,7 +50,6 @@ static const char * const excp_names[0x80] = {
>      [TT_EXTINT | 0xd] = "External Interrupt 13",
>      [TT_EXTINT | 0xe] = "External Interrupt 14",
>      [TT_EXTINT | 0xf] = "External Interrupt 15",
> -    [TT_TOVF] = "Tag Overflow",
>      [TT_CODE_ACCESS] = "Instruction Access Error",
>      [TT_DATA_ACCESS] = "Data Access Error",
>      [TT_DIV_ZERO] = "Division By Zero",

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [PATCH] target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

Posted by Laurent Vivier 3 years, 6 months ago

Le 11/10/2020 à 22:01, Philippe Mathieu-Daudé a écrit :
> Commit 0b09be2b2f ("Nicer debug output for exceptions") added
> twice the same "Tag Overflow" entry, remove the extra one.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/sparc/int32_helper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/sparc/int32_helper.c b/target/sparc/int32_helper.c
> index 9a71e1abd87..ba63c739c1e 100644
> --- a/target/sparc/int32_helper.c
> +++ b/target/sparc/int32_helper.c
> @@ -50,7 +50,6 @@ static const char * const excp_names[0x80] = {
>      [TT_EXTINT | 0xd] = "External Interrupt 13",
>      [TT_EXTINT | 0xe] = "External Interrupt 14",
>      [TT_EXTINT | 0xf] = "External Interrupt 15",
> -    [TT_TOVF] = "Tag Overflow",
>      [TT_CODE_ACCESS] = "Instruction Access Error",
>      [TT_DATA_ACCESS] = "Data Access Error",
>      [TT_DIV_ZERO] = "Division By Zero",
> 

Applied to my trivial-patches branch.

Thanks,
Laurent