testing and plugin fixes with gitdm updates (pre PR)

[PATCH v1 22/22] tests/acceptance: disable machine_rx_gdbsim on GitLab

Posted by Alex Bennée 5 years, 4 months ago

While I can get the ssh test to fail on my test setup this seems a lot
more stable except when on GitLab. Hopefully we can re-enable both
once the serial timing patches have been added.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/acceptance/machine_rx_gdbsim.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/acceptance/machine_rx_gdbsim.py b/tests/acceptance/machine_rx_gdbsim.py
index 0c72506028..32b737b6d8 100644
--- a/tests/acceptance/machine_rx_gdbsim.py
+++ b/tests/acceptance/machine_rx_gdbsim.py
@@ -22,6 +22,7 @@ class RxGdbSimMachine(Test):
     timeout = 30
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
 
+    @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
     def test_uboot(self):
         """
         U-Boot and checks that the console is operational.
-- 
2.20.1

Re: [PATCH v1 22/22] tests/acceptance: disable machine_rx_gdbsim on GitLab

Posted by Willian Rampazzo 5 years, 4 months ago

On Wed, Oct 7, 2020 at 1:37 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> While I can get the ssh test to fail on my test setup this seems a lot
> more stable except when on GitLab. Hopefully we can re-enable both
> once the serial timing patches have been added.

Fair enough!

>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/acceptance/machine_rx_gdbsim.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/acceptance/machine_rx_gdbsim.py b/tests/acceptance/machine_rx_gdbsim.py
> index 0c72506028..32b737b6d8 100644
> --- a/tests/acceptance/machine_rx_gdbsim.py
> +++ b/tests/acceptance/machine_rx_gdbsim.py
> @@ -22,6 +22,7 @@ class RxGdbSimMachine(Test):
>      timeout = 30
>      KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
>
> +    @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
>      def test_uboot(self):
>          """
>          U-Boot and checks that the console is operational.
> --
> 2.20.1
>
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>

Re: [PATCH v1 22/22] tests/acceptance: disable machine_rx_gdbsim on GitLab

Posted by Cleber Rosa 5 years, 4 months ago

On Wed, Oct 07, 2020 at 05:00:38PM +0100, Alex Bennée wrote:
> While I can get the ssh test to fail on my test setup this seems a lot
> more stable except when on GitLab. Hopefully we can re-enable both
> once the serial timing patches have been added.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Cleber Rosa <crosa@redhat.com>