[v7] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

[PATCH v7 00/13] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

Maxim Levitsky posted 13 patches 4 years, 12 months ago

Diff against v1 v3 v4 v5 v6 v8
Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201006123904.610658-1-mlevitsk@redhat.com

Maintainers: Laurent Vivier <lvivier@redhat.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>, Thomas Huth <thuth@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Fam Zheng <fam@euphon.net>, John Snow <jsnow@redhat.com>, Jason Wang <jasowang@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>

There is a newer version of this series

hw/core/bus.c                   |  28 ++--
hw/core/qdev.c                  |  73 ++++++---
hw/net/virtio-net.c             |   2 +-
hw/scsi/scsi-bus.c              | 262 ++++++++++++++++++++------------
hw/scsi/virtio-scsi.c           |  27 ++--
hw/sd/core.c                    |   3 +-
include/hw/qdev-core.h          |  24 ++-
include/hw/scsi/scsi.h          |   1 +
qdev-monitor.c                  |  12 ++
tests/qtest/drive_del-test.c    |   9 +-
tests/qtest/libqos/libqtest.h   |  34 +++--
tests/qtest/libqtest.c          | 110 +++++++-------
tests/qtest/migration-helpers.c |  25 ++-
tests/qtest/pvpanic-test.c      |   4 +-
tests/qtest/qmp-test.c          |  18 +--
tests/qtest/tpm-util.c          |   8 +-
16 files changed, 411 insertions(+), 229 deletions(-)

Expand all Fold all

[PATCH v7 00/13] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

Posted by Maxim Levitsky 4 years, 12 months ago

This is the next version of the patches.

In this version I implemented Paulo's suggestion of fixing the qtests
to cope with out of order events.

This resulted in small but nice refactoring.

Besides that, the only other change from V6 is that I dropped Paulo's
fix to qtest_qmp_device_del since it is fixed now by my qtest patches.

The iotest 67 still fails with this, something that Paulo
is looking to fix before merging this.

Best regards,
	Maxim Levitsky

Maxim Levitsky (10):
  qtest: rename qtest_qmp_receive to qtest_qmp_receive_dict
  qtest: Reintroduce qtest_qmp_receive
  qtest: switch users back to qtest_qmp_receive
  scsi/scsi_bus: switch search direction in scsi_device_find
  device_core: use drain_call_rcu in in qmp_device_add
  device-core: use RCU for list of children of a bus
  device-core: use atomic_set on .realized property
  scsi/scsi_bus: Add scsi_device_get
  virtio-scsi: use scsi_device_get
  scsi/scsi_bus: fix races in REPORT LUNS

Paolo Bonzini (3):
  qdev: add "check if address free" callback for buses
  scsi: switch to bus->check_address
  scsi/scsi-bus: scsi_device_find: don't return unrealized devices

 hw/core/bus.c                   |  28 ++--
 hw/core/qdev.c                  |  73 ++++++---
 hw/net/virtio-net.c             |   2 +-
 hw/scsi/scsi-bus.c              | 262 ++++++++++++++++++++------------
 hw/scsi/virtio-scsi.c           |  27 ++--
 hw/sd/core.c                    |   3 +-
 include/hw/qdev-core.h          |  24 ++-
 include/hw/scsi/scsi.h          |   1 +
 qdev-monitor.c                  |  12 ++
 tests/qtest/drive_del-test.c    |   9 +-
 tests/qtest/libqos/libqtest.h   |  34 +++--
 tests/qtest/libqtest.c          | 110 +++++++-------
 tests/qtest/migration-helpers.c |  25 ++-
 tests/qtest/pvpanic-test.c      |   4 +-
 tests/qtest/qmp-test.c          |  18 +--
 tests/qtest/tpm-util.c          |   8 +-
 16 files changed, 411 insertions(+), 229 deletions(-)

-- 
2.26.2

Re: [PATCH v7 00/13] Fix scsi devices plug/unplug races w.r.t virtio-scsi iothread

Posted by no-reply@patchew.org 4 years, 12 months ago

Patchew URL: https://patchew.org/QEMU/20201006123904.610658-1-mlevitsk@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20201006123904.610658-1-mlevitsk@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com