[v4] Support disabling TCG on ARM (part 2)

[PATCH v4 03/12] target/arm: Select SEMIHOSTING if TCG is available

Posted by Philippe Mathieu-Daudé 5 years, 4 months ago

Add a kconfig entry which not explicitly selected by another
entry, but which selects SEMIHOSTING if TCG is available.

This avoids:

  /usr/bin/ld: libqemu-aarch64-softmmu.fa.p/target_arm_arm-semi.c.o: in function `do_arm_semihosting':
  target/arm/arm-semi.c:784: undefined reference to `qemu_semihosting_console_outc'
  target/arm/arm-semi.c:787: undefined reference to `qemu_semihosting_console_outs'
  /usr/bin/ld: target/arm/arm-semi.c:815: undefined reference to `qemu_semihosting_console_inc'

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 target/arm/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 target/arm/Kconfig

diff --git a/target/arm/Kconfig b/target/arm/Kconfig
new file mode 100644
index 0000000000..972d9a1b9a
--- /dev/null
+++ b/target/arm/Kconfig
@@ -0,0 +1,4 @@
+# arch-specific rule to select SEMIHOSTING if ARM && TCG
+config ARM_SEMIHOSTING
+    default y if TCG
+    select SEMIHOSTING
-- 
2.26.2

Re: [PATCH v4 03/12] target/arm: Select SEMIHOSTING if TCG is available

Posted by Richard Henderson 5 years, 4 months ago

On 9/29/20 5:43 PM, Philippe Mathieu-Daudé wrote:
> Add a kconfig entry which not explicitly selected by another
> entry, but which selects SEMIHOSTING if TCG is available.
> 
> This avoids:
> 
>   /usr/bin/ld: libqemu-aarch64-softmmu.fa.p/target_arm_arm-semi.c.o: in function `do_arm_semihosting':
>   target/arm/arm-semi.c:784: undefined reference to `qemu_semihosting_console_outc'
>   target/arm/arm-semi.c:787: undefined reference to `qemu_semihosting_console_outs'
>   /usr/bin/ld: target/arm/arm-semi.c:815: undefined reference to `qemu_semihosting_console_inc'
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  target/arm/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
>  create mode 100644 target/arm/Kconfig

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~