1. Patchew
  2. QEMU
  3. View series

[PATCH v2 0/9] s390x/tcg: Implement some z14 facilities

David Hildenbrand posted 9 patches 3 years, 7 months ago
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
Test checkpatch failed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200928122717.30586-1-david@redhat.com
Maintainers: David Hildenbrand <david@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Richard Henderson <rth@twiddle.net>
target/s390x/cc_helper.c            | 32 +++++++++++++++++++
target/s390x/cpu_features_def.h.inc |  2 +-
target/s390x/gen-features.c         |  4 ++-
target/s390x/helper.c               |  2 ++
target/s390x/insn-data.def          | 12 ++++++++
target/s390x/internal.h             |  2 ++
target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
7 files changed, 100 insertions(+), 2 deletions(-)
[PATCH v2 0/9] s390x/tcg: Implement some z14 facilities
Posted by David Hildenbrand 3 years, 7 months ago 
With this patchset, I can boot a kernel compiled for z14 (requiring
Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max).

I am currently working on "vector-enhancements facility 1", I have most
stuff in place except:
- VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all types of
                               comparisons.

Once we have that in place, we can convert the QEMU machine to a
stripped-down z14.

v1 -> v2:
- "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
   S390_FEAT_MISC_INSTRUCTION_EXT2"
-- Added
- "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)"
-- Use new helper instead
- "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)"
-- Tune comparisons in CC computation

David Hildenbrand (9):
  s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
    S390_FEAT_MISC_INSTRUCTION_EXT2
  s390x/tcg: Implement ADD HALFWORD (AGH)
  s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
  s390x/tcg: Implement MULTIPLY (MG, MGRK)
  s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
  s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)
  s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)
  s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2
  s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)

 target/s390x/cc_helper.c            | 32 +++++++++++++++++++
 target/s390x/cpu_features_def.h.inc |  2 +-
 target/s390x/gen-features.c         |  4 ++-
 target/s390x/helper.c               |  2 ++
 target/s390x/insn-data.def          | 12 ++++++++
 target/s390x/internal.h             |  2 ++
 target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
 7 files changed, 100 insertions(+), 2 deletions(-)

-- 
2.26.2
Re: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities
Posted by no-reply@patchew.org 3 years, 7 months ago 
Patchew URL: https://patchew.org/QEMU/20200928122717.30586-1-david@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200928122717.30586-1-david@redhat.com
Subject: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200925162316.21205-1-peter.maydell@linaro.org -> patchew/20200925162316.21205-1-peter.maydell@linaro.org
 * [new tag]         patchew/20200928061201.1601-1-wangzhiqiang.bj@bytedance.com -> patchew/20200928061201.1601-1-wangzhiqiang.bj@bytedance.com
 * [new tag]         patchew/20200928092705.3730-1-wangzhiqiang.bj@bytedance.com -> patchew/20200928092705.3730-1-wangzhiqiang.bj@bytedance.com
 * [new tag]         patchew/20200928125859.734287-1-philmd@redhat.com -> patchew/20200928125859.734287-1-philmd@redhat.com
 * [new tag]         patchew/20200928131934.739451-1-philmd@redhat.com -> patchew/20200928131934.739451-1-philmd@redhat.com
Switched to a new branch 'test'
9d42c6b s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)
33bb426 s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2
749f183 s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)
48d85e6 s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)
ce04e77 s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
96f9c9c s390x/tcg: Implement MULTIPLY (MG, MGRK)
ff5b047 s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
18f2055 s390x/tcg: Implement ADD HALFWORD (AGH)
7533d8f s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2

=== OUTPUT BEGIN ===
1/9 Checking commit 7533d8fd7ca1 (s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2)
2/9 Checking commit 18f20555ed6f (s390x/tcg: Implement ADD HALFWORD (AGH))
ERROR: line over 90 characters
#34: FILE: target/s390x/translate.c:6101:
+#define FAC_MIE2        S390_FEAT_MISC_INSTRUCTION_EXT2 /* miscellaneous-instruction-extensions facility 2 */

total: 1 errors, 0 warnings, 14 lines checked

Patch 2/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/9 Checking commit ff5b0476125c (s390x/tcg: Implement SUBTRACT HALFWORD (SGH))
4/9 Checking commit 96f9c9cac0e7 (s390x/tcg: Implement MULTIPLY (MG, MGRK))
5/9 Checking commit ce04e77373db (s390x/tcg: Implement MULTIPLY HALFWORD (MGH))
6/9 Checking commit 48d85e6436bb (s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC))
7/9 Checking commit 749f183b9be4 (s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC))
8/9 Checking commit 33bb426469fd (s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2)
9/9 Checking commit 9d42c6b7f1f8 (s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA))
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200928122717.30586-1-david@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities
Posted by Cornelia Huck 3 years, 7 months ago 
On Mon, 28 Sep 2020 14:27:08 +0200
David Hildenbrand <david@redhat.com> wrote:

> With this patchset, I can boot a kernel compiled for z14 (requiring
> Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max).
> 
> I am currently working on "vector-enhancements facility 1", I have most
> stuff in place except:
> - VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all types of
>                                comparisons.
> 
> Once we have that in place, we can convert the QEMU machine to a
> stripped-down z14.
> 
> v1 -> v2:
> - "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
>    S390_FEAT_MISC_INSTRUCTION_EXT2"
> -- Added
> - "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)"
> -- Use new helper instead
> - "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)"
> -- Tune comparisons in CC computation
> 
> David Hildenbrand (9):
>   s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
>     S390_FEAT_MISC_INSTRUCTION_EXT2
>   s390x/tcg: Implement ADD HALFWORD (AGH)
>   s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
>   s390x/tcg: Implement MULTIPLY (MG, MGRK)
>   s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
>   s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)
>   s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)
>   s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2
>   s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)
> 
>  target/s390x/cc_helper.c            | 32 +++++++++++++++++++
>  target/s390x/cpu_features_def.h.inc |  2 +-
>  target/s390x/gen-features.c         |  4 ++-
>  target/s390x/helper.c               |  2 ++
>  target/s390x/insn-data.def          | 12 ++++++++
>  target/s390x/internal.h             |  2 ++
>  target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
>  7 files changed, 100 insertions(+), 2 deletions(-)
> 

Thanks, applied.
Re: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities
Posted by David Hildenbrand 3 years, 7 months ago 
On 01.10.20 19:02, Cornelia Huck wrote:
> On Mon, 28 Sep 2020 14:27:08 +0200
> David Hildenbrand <david@redhat.com> wrote:
> 
>> With this patchset, I can boot a kernel compiled for z14 (requiring
>> Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max).
>>
>> I am currently working on "vector-enhancements facility 1", I have most
>> stuff in place except:
>> - VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all types of
>>                                comparisons.
>>
>> Once we have that in place, we can convert the QEMU machine to a
>> stripped-down z14.
>>
>> v1 -> v2:
>> - "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
>>    S390_FEAT_MISC_INSTRUCTION_EXT2"
>> -- Added
>> - "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)"
>> -- Use new helper instead
>> - "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)"
>> -- Tune comparisons in CC computation
>>
>> David Hildenbrand (9):
>>   s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
>>     S390_FEAT_MISC_INSTRUCTION_EXT2
>>   s390x/tcg: Implement ADD HALFWORD (AGH)
>>   s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
>>   s390x/tcg: Implement MULTIPLY (MG, MGRK)
>>   s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
>>   s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)
>>   s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)
>>   s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2
>>   s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)
>>
>>  target/s390x/cc_helper.c            | 32 +++++++++++++++++++
>>  target/s390x/cpu_features_def.h.inc |  2 +-
>>  target/s390x/gen-features.c         |  4 ++-
>>  target/s390x/helper.c               |  2 ++
>>  target/s390x/insn-data.def          | 12 ++++++++
>>  target/s390x/internal.h             |  2 ++
>>  target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
>>  7 files changed, 100 insertions(+), 2 deletions(-)
>>
> 
> Thanks, applied.
> 

Can you rename in patch #1 subject "s390x/cpu_model" ->
"s390x/cpumodel"? Thanks!


-- 
Thanks,

David / dhildenb
Re: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities
Posted by Cornelia Huck 3 years, 7 months ago 
On Thu, 1 Oct 2020 19:03:39 +0200
David Hildenbrand <david@redhat.com> wrote:

> On 01.10.20 19:02, Cornelia Huck wrote:
> > On Mon, 28 Sep 2020 14:27:08 +0200
> > David Hildenbrand <david@redhat.com> wrote:
> >   
> >> With this patchset, I can boot a kernel compiled for z14 (requiring
> >> Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max).
> >>
> >> I am currently working on "vector-enhancements facility 1", I have most
> >> stuff in place except:
> >> - VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all types of
> >>                                comparisons.
> >>
> >> Once we have that in place, we can convert the QEMU machine to a
> >> stripped-down z14.
> >>
> >> v1 -> v2:
> >> - "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
> >>    S390_FEAT_MISC_INSTRUCTION_EXT2"
> >> -- Added
> >> - "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)"
> >> -- Use new helper instead
> >> - "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)"
> >> -- Tune comparisons in CC computation
> >>
> >> David Hildenbrand (9):
> >>   s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
> >>     S390_FEAT_MISC_INSTRUCTION_EXT2
> >>   s390x/tcg: Implement ADD HALFWORD (AGH)
> >>   s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
> >>   s390x/tcg: Implement MULTIPLY (MG, MGRK)
> >>   s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
> >>   s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)
> >>   s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)
> >>   s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2
> >>   s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)
> >>
> >>  target/s390x/cc_helper.c            | 32 +++++++++++++++++++
> >>  target/s390x/cpu_features_def.h.inc |  2 +-
> >>  target/s390x/gen-features.c         |  4 ++-
> >>  target/s390x/helper.c               |  2 ++
> >>  target/s390x/insn-data.def          | 12 ++++++++
> >>  target/s390x/internal.h             |  2 ++
> >>  target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
> >>  7 files changed, 100 insertions(+), 2 deletions(-)
> >>  
> > 
> > Thanks, applied.
> >   
> 
> Can you rename in patch #1 subject "s390x/cpu_model" ->
> "s390x/cpumodel"? Thanks!

As you wish :) Pushed out.
Re: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities
Posted by Cornelia Huck 3 years, 7 months ago 
On Mon, 28 Sep 2020 14:27:08 +0200
David Hildenbrand <david@redhat.com> wrote:

> With this patchset, I can boot a kernel compiled for z14 (requiring
> Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max).
> 
> I am currently working on "vector-enhancements facility 1", I have most
> stuff in place except:
> - VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all types of
>                                comparisons.
> 
> Once we have that in place, we can convert the QEMU machine to a
> stripped-down z14.
> 
> v1 -> v2:
> - "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
>    S390_FEAT_MISC_INSTRUCTION_EXT2"
> -- Added
> - "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)"
> -- Use new helper instead
> - "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)"
> -- Tune comparisons in CC computation
> 
> David Hildenbrand (9):
>   s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
>     S390_FEAT_MISC_INSTRUCTION_EXT2
>   s390x/tcg: Implement ADD HALFWORD (AGH)
>   s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
>   s390x/tcg: Implement MULTIPLY (MG, MGRK)
>   s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
>   s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)
>   s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)
>   s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2
>   s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)
> 
>  target/s390x/cc_helper.c            | 32 +++++++++++++++++++
>  target/s390x/cpu_features_def.h.inc |  2 +-
>  target/s390x/gen-features.c         |  4 ++-
>  target/s390x/helper.c               |  2 ++
>  target/s390x/insn-data.def          | 12 ++++++++
>  target/s390x/internal.h             |  2 ++
>  target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
>  7 files changed, 100 insertions(+), 2 deletions(-)

Working on preparing a pull request... I think this still misses review
on two patches?

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.