[PATCH v2 0/6] QOM minor fixes

Mark Cave-Ayland posted 6 patches 5 years, 1 month ago
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
Test checkpatch passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200926140216.7368-1-mark.cave-ayland@ilande.co.uk
Maintainers: Artyom Tarasenko <atar4qemu@gmail.com>, David Gibson <david@gibson.dropbear.id.au>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
hw/dma/sparc32_dma.c           | 49 +++++++++++++++++-----------------
hw/misc/macio/macio.c          |  4 ---
hw/pci-host/sabre.c            |  8 ------
hw/ppc/mac_newworld.c          |  6 +++++
hw/ppc/mac_oldworld.c          |  6 +++++
hw/sparc/sun4m.c               | 21 +++++++++------
hw/sparc64/sun4u.c             |  7 +++++
include/hw/sparc/sparc32_dma.h |  8 +++---
8 files changed, 60 insertions(+), 49 deletions(-)
[PATCH v2 0/6] QOM minor fixes
Posted by Mark Cave-Ayland 5 years, 1 month ago
This series started off as a fix for the nd_table misuse in the sparc32-ledma
device as pointed out by Markus, and then I remembered there was similar
issue around the use of serial_hd() in macio. The last patch is one I've had
sitting in a local branch for a while and is a mistake I made during the
original sabre.c split which seems appropriate to include here.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

v2:
- Rebase onto master
- Add R-B tags from Philippe
- Remove user_creatable=true from patch 5 as pointed out by Zoltan


Mark Cave-Ayland (6):
  sparc32-dma: use object_initialize_child() for espdma and ledma child
    objects
  sparc32-ledma: use object_initialize_child() for lance child object
  sparc32-espdma: use object_initialize_child() for esp child object
  sparc32-ledma: don't reference nd_table directly within the device
  macio: don't reference serial_hd() directly within the device
  sabre: don't call sysbus_mmio_map() in sabre_realize()

 hw/dma/sparc32_dma.c           | 49 +++++++++++++++++-----------------
 hw/misc/macio/macio.c          |  4 ---
 hw/pci-host/sabre.c            |  8 ------
 hw/ppc/mac_newworld.c          |  6 +++++
 hw/ppc/mac_oldworld.c          |  6 +++++
 hw/sparc/sun4m.c               | 21 +++++++++------
 hw/sparc64/sun4u.c             |  7 +++++
 include/hw/sparc/sparc32_dma.h |  8 +++---
 8 files changed, 60 insertions(+), 49 deletions(-)

-- 
2.20.1


Re: [PATCH v2 0/6] QOM minor fixes
Posted by Mark Cave-Ayland 5 years ago
On 26/09/2020 15:02, Mark Cave-Ayland wrote:

> This series started off as a fix for the nd_table misuse in the sparc32-ledma
> device as pointed out by Markus, and then I remembered there was similar
> issue around the use of serial_hd() in macio. The last patch is one I've had
> sitting in a local branch for a while and is a mistake I made during the
> original sabre.c split which seems appropriate to include here.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> v2:
> - Rebase onto master
> - Add R-B tags from Philippe
> - Remove user_creatable=true from patch 5 as pointed out by Zoltan
> 
> 
> Mark Cave-Ayland (6):
>    sparc32-dma: use object_initialize_child() for espdma and ledma child
>      objects
>    sparc32-ledma: use object_initialize_child() for lance child object
>    sparc32-espdma: use object_initialize_child() for esp child object
>    sparc32-ledma: don't reference nd_table directly within the device
>    macio: don't reference serial_hd() directly within the device
>    sabre: don't call sysbus_mmio_map() in sabre_realize()
> 
>   hw/dma/sparc32_dma.c           | 49 +++++++++++++++++-----------------
>   hw/misc/macio/macio.c          |  4 ---
>   hw/pci-host/sabre.c            |  8 ------
>   hw/ppc/mac_newworld.c          |  6 +++++
>   hw/ppc/mac_oldworld.c          |  6 +++++
>   hw/sparc/sun4m.c               | 21 +++++++++------
>   hw/sparc64/sun4u.c             |  7 +++++
>   include/hw/sparc/sparc32_dma.h |  8 +++---
>   8 files changed, 60 insertions(+), 49 deletions(-)

I've applied this series (minus patch 5 the macio change which has been merged 
separately via my qemu-macppc branch) to my qemu-sparc branch.


ATB,

Mark.