[v1] modules: update qom object module comment

[PATCH] modules: update qom object module comment

Gerd Hoffmann posted 1 patch 5 years, 1 month ago

Diff against v2
Download mbox

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200923091812.27297-1-kraxel@redhat.com

There is a newer version of this series

util/module.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] modules: update qom object module comment

Posted by Gerd Hoffmann 5 years, 1 month ago

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 util/module.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/util/module.c b/util/module.c
index 520986bd70ff..6df873593f95 100644
--- a/util/module.c
+++ b/util/module.c
@@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
  * only a very few devices & objects.
  *
  * So with the expectation that this will be rather the exception than
- * to rule and the list will not gain that many entries go with a
+ * to rule and the list will not gain that many entries, go with a
  * simple manually maintained list for now.
+ *
+ * The list must be sorted by module (module_load_qom_all() needs this).
  */
 static struct {
     const char *type;
-- 
2.27.0

Re: [PATCH] modules: update qom object module comment

Posted by Philippe Mathieu-Daudé 5 years, 1 month ago

On 9/23/20 11:18 AM, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  util/module.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/util/module.c b/util/module.c
> index 520986bd70ff..6df873593f95 100644
> --- a/util/module.c
> +++ b/util/module.c
> @@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
>   * only a very few devices & objects.
>   *
>   * So with the expectation that this will be rather the exception than
> - * to rule and the list will not gain that many entries go with a
> + * to rule and the list will not gain that many entries, go with a

"than the rule"?

>   * simple manually maintained list for now.
> + *
> + * The list must be sorted by module (module_load_qom_all() needs this).
>   */
>  static struct {
>      const char *type;
>