migration/multifd: Remove superfluous semicolons

[PATCH] migration/multifd: Remove superfluous semicolons

Posted by Philippe Mathieu-Daudé 5 years, 4 months ago

checkpatch.pl report superfluous semicolons since commit
ee0f3c09e01, but this one was missed:

  scripts/checkpatch.pl d32ca5ad798~..d32ca5ad798
  ERROR: superfluous trailing semicolon
  #498: FILE: migration/multifd.c:308:
  +    ram_counters.transferred += transferred;;
  total: 1 errors, 1 warnings, 2073 lines checked

Fixes: d32ca5ad798 ("multifd: Split multifd code into its own file")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 migration/multifd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/multifd.c b/migration/multifd.c
index d0441202aae..8aaa2f9ade1 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -447,7 +447,7 @@ static int multifd_send_pages(QEMUFile *f)
                 + p->packet_len;
     qemu_file_update_transfer(f, transferred);
     ram_counters.multifd_bytes += transferred;
-    ram_counters.transferred += transferred;;
+    ram_counters.transferred += transferred;
     qemu_mutex_unlock(&p->mutex);
     qemu_sem_post(&p->sem);
 
-- 
2.26.2

Re: [PATCH] migration/multifd: Remove superfluous semicolons

Posted by Li Qiang 5 years, 4 months ago

Philippe Mathieu-Daudé <f4bug@amsat.org> 于2020年9月21日周一 下午12:03写道：
>
> checkpatch.pl report superfluous semicolons since commit
> ee0f3c09e01, but this one was missed:
>
>   scripts/checkpatch.pl d32ca5ad798~..d32ca5ad798
>   ERROR: superfluous trailing semicolon
>   #498: FILE: migration/multifd.c:308:
>   +    ram_counters.transferred += transferred;;
>   total: 1 errors, 1 warnings, 2073 lines checked
>
> Fixes: d32ca5ad798 ("multifd: Split multifd code into its own file")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Li Qiang <liq3ea@gmail.com>

> ---
>  migration/multifd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/multifd.c b/migration/multifd.c
> index d0441202aae..8aaa2f9ade1 100644
> --- a/migration/multifd.c
> +++ b/migration/multifd.c
> @@ -447,7 +447,7 @@ static int multifd_send_pages(QEMUFile *f)
>                  + p->packet_len;
>      qemu_file_update_transfer(f, transferred);
>      ram_counters.multifd_bytes += transferred;
> -    ram_counters.transferred += transferred;;
> +    ram_counters.transferred += transferred;
>      qemu_mutex_unlock(&p->mutex);
>      qemu_sem_post(&p->sem);
>
> --
> 2.26.2
>
>

Re: [PATCH] migration/multifd: Remove superfluous semicolons

Posted by Laurent Vivier 5 years, 4 months ago

Le 21/09/2020 à 06:02, Philippe Mathieu-Daudé a écrit :
> checkpatch.pl report superfluous semicolons since commit
> ee0f3c09e01, but this one was missed:
> 
>   scripts/checkpatch.pl d32ca5ad798~..d32ca5ad798
>   ERROR: superfluous trailing semicolon
>   #498: FILE: migration/multifd.c:308:
>   +    ram_counters.transferred += transferred;;
>   total: 1 errors, 1 warnings, 2073 lines checked
> 
> Fixes: d32ca5ad798 ("multifd: Split multifd code into its own file")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  migration/multifd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/multifd.c b/migration/multifd.c
> index d0441202aae..8aaa2f9ade1 100644
> --- a/migration/multifd.c
> +++ b/migration/multifd.c
> @@ -447,7 +447,7 @@ static int multifd_send_pages(QEMUFile *f)
>                  + p->packet_len;
>      qemu_file_update_transfer(f, transferred);
>      ram_counters.multifd_bytes += transferred;
> -    ram_counters.transferred += transferred;;
> +    ram_counters.transferred += transferred;
>      qemu_mutex_unlock(&p->mutex);
>      qemu_sem_post(&p->sem);
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent