Add *.pyc back to the .gitignore file

[PATCH] Add *.pyc back to the .gitignore file

Thomas Huth posted 1 patch 3 years, 7 months ago

Download mbox

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test checkpatch passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200919101859.28739-1-thuth@redhat.com

.gitignore | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] Add *.pyc back to the .gitignore file

Posted by Thomas Huth 3 years, 7 months ago

Python still dumps its bytecode into the source directory, so
we should continue to ignore the *.pyc files.

Fixes: 0e72b7df4d ("Simplify the .gitignore file")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 5515f595e6..b32bca1315 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,6 @@
 /GNUmakefile
 /build/
+*.pyc
 .sdk
 .stgit-*
 .git-submodule-status
-- 
2.18.2

Re: [PATCH] Add *.pyc back to the .gitignore file

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

On 9/19/20 12:18 PM, Thomas Huth wrote:
> Python still dumps its bytecode into the source directory, so
> we should continue to ignore the *.pyc files.
> 
> Fixes: 0e72b7df4d ("Simplify the .gitignore file")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 5515f595e6..b32bca1315 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,5 +1,6 @@
>  /GNUmakefile
>  /build/
> +*.pyc
>  .sdk
>  .stgit-*
>  .git-submodule-status
> 

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH] Add *.pyc back to the .gitignore file

Posted by Laurent Vivier 3 years, 7 months ago

Le 19/09/2020 à 12:18, Thomas Huth a écrit :
> Python still dumps its bytecode into the source directory, so
> we should continue to ignore the *.pyc files.
> 
> Fixes: 0e72b7df4d ("Simplify the .gitignore file")
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 5515f595e6..b32bca1315 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,5 +1,6 @@
>  /GNUmakefile
>  /build/
> +*.pyc
>  .sdk
>  .stgit-*
>  .git-submodule-status
> 

Applied to my trivial-patches branch.

Thanks,
Laurent