[PATCH v5 0/4] Fixes curses on msys2/mingw

Yonggang Luo posted 4 patches 3 years, 7 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
configure                 | 155 ++------------------------------------
include/sysemu/os-win32.h |   4 +-
meson.build               |  80 +++++++++++++++++---
meson_options.txt         |   4 +
ui/curses.c               |  14 ++--
ui/meson.build            |   2 +-
util/oslib-win32.c        |   4 +-
7 files changed, 91 insertions(+), 172 deletions(-)
[PATCH v5 0/4] Fixes curses on msys2/mingw
Posted by Yonggang Luo 3 years, 7 months ago
And also convert related configure script to meson.

Yonggang Luo (4):
  curses: Fixes compiler error that complain don't have langinfo.h on
    msys2/mingw
  curses: Fixes curses compiling errors.
  win32: Simplify gmtime_r detection not depends on if  _POSIX_C_SOURCE
    are defined on msys2/mingw
  configure: Fixes ncursesw detection under msys2/mingw by convert them
    to meson

 configure                 | 155 ++------------------------------------
 include/sysemu/os-win32.h |   4 +-
 meson.build               |  80 +++++++++++++++++---
 meson_options.txt         |   4 +
 ui/curses.c               |  14 ++--
 ui/meson.build            |   2 +-
 util/oslib-win32.c        |   4 +-
 7 files changed, 91 insertions(+), 172 deletions(-)

-- 
2.28.0.windows.1


Re: [PATCH v5 0/4] Fixes curses on msys2/mingw
Posted by 罗勇刚 (Yonggang Luo) 3 years, 7 months ago
Hi Bonzini, help to look at this, I convert curses and it's depends iconv
to meson

On Sat, Sep 19, 2020 at 12:03 AM Yonggang Luo <luoyonggang@gmail.com> wrote:
>
> And also convert related configure script to meson.
>
> Yonggang Luo (4):
>   curses: Fixes compiler error that complain don't have langinfo.h on
>     msys2/mingw
>   curses: Fixes curses compiling errors.
>   win32: Simplify gmtime_r detection not depends on if  _POSIX_C_SOURCE
>     are defined on msys2/mingw
>   configure: Fixes ncursesw detection under msys2/mingw by convert them
>     to meson
>
>  configure                 | 155 ++------------------------------------
>  include/sysemu/os-win32.h |   4 +-
>  meson.build               |  80 +++++++++++++++++---
>  meson_options.txt         |   4 +
>  ui/curses.c               |  14 ++--
>  ui/meson.build            |   2 +-
>  util/oslib-win32.c        |   4 +-
>  7 files changed, 91 insertions(+), 172 deletions(-)
>
> --
> 2.28.0.windows.1
>


--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo
Re: [PATCH v5 0/4] Fixes curses on msys2/mingw
Posted by Paolo Bonzini 3 years, 7 months ago
On 18/09/20 18:10, 罗勇刚(Yonggang Luo) wrote:
> 
>> Yonggang Luo (4):
>>   curses: Fixes compiler error that complain don't have langinfo.h on
>>     msys2/mingw
>>   curses: Fixes curses compiling errors.
>>   win32: Simplify gmtime_r detection not depends on if  _POSIX_C_SOURCE
>>     are defined on msys2/mingw
>>   configure: Fixes ncursesw detection under msys2/mingw by convert them
>>     to meson

Hi, patches 1-3 are okay, but for patch 4 I think it's better to wait
for Meson 0.56 which will likely embed all the magic needed to test
curses (https://github.com/mesonbuild/meson/pull/7757).

Paolo


Re: [PATCH v5 0/4] Fixes curses on msys2/mingw
Posted by 罗勇刚 (Yonggang Luo) 3 years, 7 months ago
On Sat, Sep 19, 2020 at 11:03 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 18/09/20 18:10, 罗勇刚(Yonggang Luo) wrote:
> >
> >> Yonggang Luo (4):
> >>   curses: Fixes compiler error that complain don't have langinfo.h on
> >>     msys2/mingw
> >>   curses: Fixes curses compiling errors.
> >>   win32: Simplify gmtime_r detection not depends on if  _POSIX_C_SOURCE
> >>     are defined on msys2/mingw
> >>   configure: Fixes ncursesw detection under msys2/mingw by convert them
> >>     to meson
>
> Hi, patches 1-3 are okay, but for patch 4 I think it's better to wait
> for Meson 0.56 which will likely embed all the magic needed to test
> curses (https://github.com/mesonbuild/meson/pull/7757).
>
> Paolo
>
Wonderfull, I think there is no need fixing configure anymore, so I convert
it to meson

Waiting https://github.com/mesonbuild/meson/pull/7757 to be merged.
In deed when I convert to meson, I am facing a problem that
DNCURSES_WIDECHAR  can not be tested with the library.

--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo