[v2] block: deal with errp: part I

[PATCH v2 00/13] block: deal with errp: part I

Vladimir Sementsov-Ogievskiy posted 13 patches 3 years, 7 months ago

Diff against v1 v3 v4 v5 v6 v7
Download series mbox

Test FreeBSD failed

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200917195519.19589-1-vsementsov@virtuozzo.com

Maintainers: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Stefan Hajnoczi <stefanha@redhat.com>, Eric Blake <eblake@redhat.com>, Alberto Garcia <berto@igalia.com>, Kevin Wolf <kwolf@redhat.com>, Ari Sundholm <ari@tuxera.com>, Max Reitz <mreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, John Snow <jsnow@redhat.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

block/qcow2.h               |  9 ++---
include/block/block.h       | 12 +++----
include/block/blockjob.h    |  2 +-
block.c                     | 50 +++++++++++++++-------------
block/backup-top.c          | 20 +++++-------
block/blkdebug.c            |  6 ++--
block/blklogwrites.c        | 10 +++---
block/blkreplay.c           |  6 ++--
block/blkverify.c           | 11 +++----
block/commit.c              |  5 +--
block/mirror.c              | 18 ++++------
block/qcow2-bitmap.c        | 65 +++++++++++++++++++------------------
block/qcow2.c               | 53 ++++++++++++------------------
block/qed.c                 | 24 +++++++++-----
block/quorum.c              |  6 ++--
blockdev.c                  |  7 ++--
blockjob.c                  | 18 +++++-----
tests/test-bdrv-graph-mod.c |  6 ++--
18 files changed, 150 insertions(+), 178 deletions(-)

Expand all Fold all

[PATCH v2 00/13] block: deal with errp: part I

Posted by Vladimir Sementsov-Ogievskiy 3 years, 7 months ago

v2:
01-07: add Greg's and Alberto's r-bs
08: fix wording in commit message
    add Greg's r-b
09: fix header_updated logic, add comment, drop unrelated style-change [Alberto]
10: - fix commit header
    - add note about ERRP_GUARD in commit message
    - add Greg's r-b
11: add Greg's and Alberto's r-bs
12: was "[PATCH 13/14] block/qcow2: qcow2_do_open: deal with errp"
    - drop wrong update of qcow2_do_open() (and ERRP_GUARD() fix
        for qcow2_do_open becomes unrelated, drop it too, will
        update later)
    - reword commit message correspondingly
13: add Alberto's r-b

"[PATCH 07/14] block/blklogwrites: drop error propagation" is dropped
for now, as it needs separate small series.

Vladimir Sementsov-Ogievskiy (13):
  block: return status from bdrv_append and friends
  block: use return status of bdrv_append()
  block: check return value of bdrv_open_child and drop error
    propagation
  blockdev: fix drive_backup_prepare() missed error
  block: drop extra error propagation for bdrv_set_backing_hd
  block/mirror: drop extra error propagation in commit_active_start()
  blockjob: return status from block_job_set_speed()
  block/qcow2: qcow2_get_specific_info(): drop error propagation
  block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface
  block/qcow2-bitmap: return status from
    qcow2_store_persistent_dirty_bitmaps
  block/qcow2: read_cache_sizes: return status value
  block/qcow2: simplify qcow2_co_invalidate_cache()
  block/qed: bdrv_qed_do_open: deal with errp

 block/qcow2.h               |  9 ++---
 include/block/block.h       | 12 +++----
 include/block/blockjob.h    |  2 +-
 block.c                     | 50 +++++++++++++++-------------
 block/backup-top.c          | 20 +++++-------
 block/blkdebug.c            |  6 ++--
 block/blklogwrites.c        | 10 +++---
 block/blkreplay.c           |  6 ++--
 block/blkverify.c           | 11 +++----
 block/commit.c              |  5 +--
 block/mirror.c              | 18 ++++------
 block/qcow2-bitmap.c        | 65 +++++++++++++++++++------------------
 block/qcow2.c               | 53 ++++++++++++------------------
 block/qed.c                 | 24 +++++++++-----
 block/quorum.c              |  6 ++--
 blockdev.c                  |  7 ++--
 blockjob.c                  | 18 +++++-----
 tests/test-bdrv-graph-mod.c |  6 ++--
 18 files changed, 150 insertions(+), 178 deletions(-)

-- 
2.21.3

Re: [PATCH v2 00/13] block: deal with errp: part I

Posted by no-reply@patchew.org 3 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20200917195519.19589-1-vsementsov@virtuozzo.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.






The full log is available at
http://patchew.org/logs/20200917195519.19589-1-vsementsov@virtuozzo.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH v2 00/13] block: deal with errp: part I

Posted by Vladimir Sementsov-Ogievskiy 3 years, 7 months ago

17.09.2020 23:15, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20200917195519.19589-1-vsementsov@virtuozzo.com/
> 
> 
> 
> Hi,
> 
> This series failed build test on FreeBSD host. Please find the details below.
> 
> 
> 
> 
> 
> 
> The full log is available at
> http://patchew.org/logs/20200917195519.19589-1-vsementsov@virtuozzo.com/testing.FreeBSD/?type=message.

Link is broken, it shows: "N/A. Internal error while reading log file"


-- 
Best regards,
Vladimir