[PATCH 0/2] meson: move libmpathpersist test

Paolo Bonzini posted 2 patches 3 years, 7 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200916162621.100141-1-pbonzini@redhat.com
configure         | 91 +++--------------------------------------------
meson.build       | 83 +++++++++++++++++++++++++++++++++++++-----
meson_options.txt |  2 ++
3 files changed, 80 insertions(+), 96 deletions(-)
[PATCH 0/2] meson: move libmpathpersist test
Posted by Paolo Bonzini 3 years, 7 months ago
Move the libmpathpersist test, as well as its dependency
libudev, to meson.  This should fix or help debugging
https://travis-ci.com/github/huth/qemu/jobs/385737549#L4528

Paolo Bonzini (2):
  meson: move libudev test
  meson: move libmpathpersist test

 configure         | 91 +++--------------------------------------------
 meson.build       | 83 +++++++++++++++++++++++++++++++++++++-----
 meson_options.txt |  2 ++
 3 files changed, 80 insertions(+), 96 deletions(-)

-- 
2.26.2


Re: [PATCH 0/2] meson: move libmpathpersist test
Posted by Thomas Huth 3 years, 7 months ago
On 16/09/2020 18.26, Paolo Bonzini wrote:
> Move the libmpathpersist test, as well as its dependency
> libudev, to meson.  This should fix or help debugging
> https://travis-ci.com/github/huth/qemu/jobs/385737549#L4528

Thanks, this indeed decreased the amount of linker errors after I
applied the patches, but there are still two errors left:

 https://travis-ci.com/github/huth/qemu/jobs/385871016#L7839

Any ideas?

 Thomas


Re: [PATCH 0/2] meson: move libmpathpersist test
Posted by Paolo Bonzini 3 years, 7 months ago
On 17/09/20 11:59, Thomas Huth wrote:
> On 16/09/2020 18.26, Paolo Bonzini wrote:
>> Move the libmpathpersist test, as well as its dependency
>> libudev, to meson.  This should fix or help debugging
>> https://travis-ci.com/github/huth/qemu/jobs/385737549#L4528
> 
> Thanks, this indeed decreased the amount of linker errors after I
> applied the patches, but there are still two errors left:
> 
>  https://travis-ci.com/github/huth/qemu/jobs/385871016#L7839

libmultipath has a libdevmapper dependency, but the cc.links() test does
not use the library enough to find the problem.

There are more dependencies reported by ldd (liburcu, libaio,
libsystemd, libgcrypt, libpcre2) so if this breaks again it's probably
best to exclude scsi/qemu-pr-helper from statically-linked builds.  In
the meanwhile I'll prepare a v2.

Paolo