[PATCH] vhost-vdpa: fix indentation in vdpa_ops

Stefano Garzarella posted 1 patch 3 years, 7 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200916152634.56917-1-sgarzare@redhat.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>
hw/virtio/vhost-vdpa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] vhost-vdpa: fix indentation in vdpa_ops
Posted by Stefano Garzarella 3 years, 7 months ago
This patch fixes wrong indentation of some vdpa_ops fields introduced
with the initial commit 108a64818e ("vhost-vdpa: introduce vhost-vdpa
backend")

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
 hw/virtio/vhost-vdpa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 4580f3efd8..e123837a55 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -469,6 +469,6 @@ const VhostOps vdpa_ops = {
         .vhost_send_device_iotlb_msg = NULL,
         .vhost_dev_start = vhost_vdpa_dev_start,
         .vhost_get_device_id = vhost_vdpa_get_device_id,
-         .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
-         .vhost_force_iommu = vhost_vdpa_force_iommu,
+        .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
+        .vhost_force_iommu = vhost_vdpa_force_iommu,
 };
-- 
2.26.2


Re: [PATCH] vhost-vdpa: fix indentation in vdpa_ops
Posted by Li Qiang 3 years, 7 months ago
Stefano Garzarella <sgarzare@redhat.com> 于2020年9月16日周三 下午11:27写道:
>
> This patch fixes wrong indentation of some vdpa_ops fields introduced
> with the initial commit 108a64818e ("vhost-vdpa: introduce vhost-vdpa
> backend")
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>

Reviewed-by: Li Qiang <liq3ea@gmail.com>

> ---
>  hw/virtio/vhost-vdpa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 4580f3efd8..e123837a55 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -469,6 +469,6 @@ const VhostOps vdpa_ops = {
>          .vhost_send_device_iotlb_msg = NULL,
>          .vhost_dev_start = vhost_vdpa_dev_start,
>          .vhost_get_device_id = vhost_vdpa_get_device_id,
> -         .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
> -         .vhost_force_iommu = vhost_vdpa_force_iommu,
> +        .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
> +        .vhost_force_iommu = vhost_vdpa_force_iommu,
>  };
> --
> 2.26.2
>
>

Re: [PATCH] vhost-vdpa: fix indentation in vdpa_ops
Posted by Laurent Vivier 3 years, 7 months ago
Le 16/09/2020 à 17:26, Stefano Garzarella a écrit :
> This patch fixes wrong indentation of some vdpa_ops fields introduced
> with the initial commit 108a64818e ("vhost-vdpa: introduce vhost-vdpa
> backend")
> 
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  hw/virtio/vhost-vdpa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> index 4580f3efd8..e123837a55 100644
> --- a/hw/virtio/vhost-vdpa.c
> +++ b/hw/virtio/vhost-vdpa.c
> @@ -469,6 +469,6 @@ const VhostOps vdpa_ops = {
>          .vhost_send_device_iotlb_msg = NULL,
>          .vhost_dev_start = vhost_vdpa_dev_start,
>          .vhost_get_device_id = vhost_vdpa_get_device_id,
> -         .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
> -         .vhost_force_iommu = vhost_vdpa_force_iommu,
> +        .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
> +        .vhost_force_iommu = vhost_vdpa_force_iommu,
>  };
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

CC: Jason (he already has a cleanup series for vDPA)

Re: [PATCH] vhost-vdpa: fix indentation in vdpa_ops
Posted by Laurent Vivier 3 years, 7 months ago
Le 16/09/2020 à 17:48, Laurent Vivier a écrit :
> Le 16/09/2020 à 17:26, Stefano Garzarella a écrit :
>> This patch fixes wrong indentation of some vdpa_ops fields introduced
>> with the initial commit 108a64818e ("vhost-vdpa: introduce vhost-vdpa
>> backend")
>>
>> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
>> ---
>>  hw/virtio/vhost-vdpa.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
>> index 4580f3efd8..e123837a55 100644
>> --- a/hw/virtio/vhost-vdpa.c
>> +++ b/hw/virtio/vhost-vdpa.c
>> @@ -469,6 +469,6 @@ const VhostOps vdpa_ops = {
>>          .vhost_send_device_iotlb_msg = NULL,
>>          .vhost_dev_start = vhost_vdpa_dev_start,
>>          .vhost_get_device_id = vhost_vdpa_get_device_id,
>> -         .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
>> -         .vhost_force_iommu = vhost_vdpa_force_iommu,
>> +        .vhost_vq_get_addr = vhost_vdpa_vq_get_addr,
>> +        .vhost_force_iommu = vhost_vdpa_force_iommu,
>>  };
>>
> 
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> 
> CC: Jason (he already has a cleanup series for vDPA)
> 


Applied to my trivial-patches branch.

Thanks,
Laurent