[PATCH] virtiofsd: document cache=auto default

Stefan Hajnoczi posted 1 patch 2 weeks ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200916112250.760245-1-stefanha@redhat.com
docs/tools/virtiofsd.rst | 1 +
1 file changed, 1 insertion(+)

[PATCH] virtiofsd: document cache=auto default

Posted by Stefan Hajnoczi 2 weeks ago
From: "Harry G. Coin" <hgcoin@gmail.com>

The virtiofsd --help output documents the cache=auto default value but
the man page does not. Fix this.

Signed-off-by: Harry G. Coin <hgcoin@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 docs/tools/virtiofsd.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
index e33c81ed41..352a29ce3c 100644
--- a/docs/tools/virtiofsd.rst
+++ b/docs/tools/virtiofsd.rst
@@ -103,6 +103,7 @@ Options
   forbids the FUSE client from caching to achieve best coherency at the cost of
   performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
   timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
+  The default is ``auto``.
 
 Examples
 --------
-- 
2.26.2

Re: [PATCH] virtiofsd: document cache=auto default

Posted by Dr. David Alan Gilbert 6 days ago
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> From: "Harry G. Coin" <hgcoin@gmail.com>
> 
> The virtiofsd --help output documents the cache=auto default value but
> the man page does not. Fix this.
> 
> Signed-off-by: Harry G. Coin <hgcoin@gmail.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Queued

> ---
>  docs/tools/virtiofsd.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index e33c81ed41..352a29ce3c 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -103,6 +103,7 @@ Options
>    forbids the FUSE client from caching to achieve best coherency at the cost of
>    performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
>    timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
> +  The default is ``auto``.
>  
>  Examples
>  --------
> -- 
> 2.26.2
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK


Re: [PATCH] virtiofsd: document cache=auto default

Posted by Dr. David Alan Gilbert 1 week ago
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> From: "Harry G. Coin" <hgcoin@gmail.com>
> 
> The virtiofsd --help output documents the cache=auto default value but
> the man page does not. Fix this.
> 
> Signed-off-by: Harry G. Coin <hgcoin@gmail.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Thanks, I'll add it to the next pull.

Dave


> ---
>  docs/tools/virtiofsd.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index e33c81ed41..352a29ce3c 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -103,6 +103,7 @@ Options
>    forbids the FUSE client from caching to achieve best coherency at the cost of
>    performance.  ``auto`` acts similar to NFS with a 1 second metadata cache
>    timeout.  ``always`` sets a long cache lifetime at the expense of coherency.
> +  The default is ``auto``.
>  
>  Examples
>  --------
> -- 
> 2.26.2
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK