[v2] qom: Allow object to be aligned

[PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo

Richard Henderson posted 6 patches 5 years, 4 months ago

Diff against v1
Download mbox

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Alistair Francis <Alistair.Francis@wdc.com>, David Hildenbrand <david@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Palmer Dabbelt <palmer@dabbelt.com>, Thomas Huth <thuth@redhat.com>, Stefan Weil <sw@weilnetz.de>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>, Sagar Karandikar <sagark@eecs.berkeley.edu>

Expand all Fold all

[PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo

Posted by Richard Henderson 5 years, 4 months ago

Fix alignment of CPUPPCState.vsr.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
Cc: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org
---
 target/ppc/translate_init.c.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.inc
index 230a062d29..accb4f2fae 100644
--- a/target/ppc/translate_init.c.inc
+++ b/target/ppc/translate_init.c.inc
@@ -10960,6 +10960,7 @@ static const TypeInfo ppc_cpu_type_info = {
     .name = TYPE_POWERPC_CPU,
     .parent = TYPE_CPU,
     .instance_size = sizeof(PowerPCCPU),
+    .instance_align = __alignof__(PowerPCCPU),
     .instance_init = ppc_cpu_instance_init,
     .instance_finalize = ppc_cpu_instance_finalize,
     .abstract = true,
-- 
2.25.1

Re: [PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo

Posted by David Gibson 5 years, 4 months ago

On Tue, Sep 15, 2020 at 05:46:36PM -0700, Richard Henderson wrote:
> Fix alignment of CPUPPCState.vsr.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

LGTM

Acked-by: David Gibson <david@gibson.dropbear.id.au>

> ---
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: qemu-ppc@nongnu.org
> ---
>  target/ppc/translate_init.c.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/ppc/translate_init.c.inc b/target/ppc/translate_init.c.inc
> index 230a062d29..accb4f2fae 100644
> --- a/target/ppc/translate_init.c.inc
> +++ b/target/ppc/translate_init.c.inc
> @@ -10960,6 +10960,7 @@ static const TypeInfo ppc_cpu_type_info = {
>      .name = TYPE_POWERPC_CPU,
>      .parent = TYPE_CPU,
>      .instance_size = sizeof(PowerPCCPU),
> +    .instance_align = __alignof__(PowerPCCPU),
>      .instance_init = ppc_cpu_instance_init,
>      .instance_finalize = ppc_cpu_instance_finalize,
>      .abstract = true,

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign
[PATCH v2 2/6] qom: Allow objects to be allocated with increased alignment
[PATCH v2 3/6] target/arm: Set instance_align on CPUARM TypeInfo
[PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo
[PATCH v2 5/6] target/riscv: Set instance_align on RISCVCPU TypeInfo
[PATCH v2 6/6] target/s390x: Set instance_align on S390CPU TypeInfo