configure: add missing CONFIG_FOO variables

[PATCH 0/3] configure: add missing CONFIG_FOO variables

Stefan Hajnoczi posted 3 patches 3 years, 7 months ago

Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200914095231.621068-1-stefanha@redhat.com

configure   | 10 +++++++++-
Makefile    |  2 +-
meson.build |  2 +-
3 files changed, 11 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH 0/3] configure: add missing CONFIG_FOO variables

Posted by Stefan Hajnoczi 3 years, 7 months ago

The meson.build feature summary checks the presence of CONFIG_FOO variables.
Several of these variables are never emitted by ./configure so the feature
summary always shows these features as disabled.

Stefan Hajnoczi (3):
  configure: add missing CONFIG_TCMALLOC
  configure: add missing CONFIG_JEMALLOC
  configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI

 configure   | 10 +++++++++-
 Makefile    |  2 +-
 meson.build |  2 +-
 3 files changed, 11 insertions(+), 3 deletions(-)

-- 
2.26.2

Re: [PATCH 0/3] configure: add missing CONFIG_FOO variables

Posted by Paolo Bonzini 3 years, 7 months ago

On 14/09/20 11:52, Stefan Hajnoczi wrote:
> The meson.build feature summary checks the presence of CONFIG_FOO variables.
> Several of these variables are never emitted by ./configure so the feature
> summary always shows these features as disabled.
> 
> Stefan Hajnoczi (3):
>   configure: add missing CONFIG_TCMALLOC
>   configure: add missing CONFIG_JEMALLOC
>   configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI
> 
>  configure   | 10 +++++++++-
>  Makefile    |  2 +-
>  meson.build |  2 +-
>  3 files changed, 11 insertions(+), 3 deletions(-)
> 

Thanks!

For 1 and 2 I think it's simpler to move the whole test to Meson.  I
already have a patch for that, though I was going to send it next week.

Paolo

Re: [PATCH 0/3] configure: add missing CONFIG_FOO variables

Posted by Stefan Hajnoczi 3 years, 7 months ago

On Mon, Sep 14, 2020 at 12:50:23PM +0200, Paolo Bonzini wrote:
> On 14/09/20 11:52, Stefan Hajnoczi wrote:
> > The meson.build feature summary checks the presence of CONFIG_FOO variables.
> > Several of these variables are never emitted by ./configure so the feature
> > summary always shows these features as disabled.
> > 
> > Stefan Hajnoczi (3):
> >   configure: add missing CONFIG_TCMALLOC
> >   configure: add missing CONFIG_JEMALLOC
> >   configure: rename QEMU_GA_MSI_ENABLED to CONFIG_QGA_MSI
> > 
> >  configure   | 10 +++++++++-
> >  Makefile    |  2 +-
> >  meson.build |  2 +-
> >  3 files changed, 11 insertions(+), 3 deletions(-)
> > 
> 
> Thanks!
> 
> For 1 and 2 I think it's simpler to move the whole test to Meson.  I
> already have a patch for that, though I was going to send it next week.

Great, it's nice to do feature checks in meson instead of ./configure.

Stefan