[PATCH v5 0/8] user-mode: Prune build dependencies (part 2)

Philippe Mathieu-Daudé posted 8 patches 3 years, 7 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200913195348.1064154-1-philmd@redhat.com
qapi/acpi.json                       | 141 +++++
qapi/machine.json                    | 388 +++++++++++++
qapi/misc.json                       | 820 ---------------------------
qapi/pci.json                        | 316 +++++++++++
qapi/qapi-schema.json                |   2 +
include/hw/acpi/acpi_dev_interface.h |   2 +-
include/hw/mem/memory-device.h       |   2 +-
include/hw/rtc/mc146818rtc.h         |   2 +-
include/hw/virtio/virtio-pmem.h      |   2 +-
include/sysemu/balloon.h             |   2 +-
block/iscsi.c                        |   2 +-
hw/acpi/core.c                       |   2 +-
hw/acpi/cpu.c                        |   2 +-
hw/acpi/memory_hotplug.c             |   3 +-
hw/acpi/vmgenid.c                    |   2 +-
hw/core/qdev-properties.c            |   1 +
hw/i386/kvm/i8254.c                  |   2 +-
hw/pci/pci-stub.c                    |   2 +-
hw/pci/pci.c                         |   2 +-
hw/virtio/virtio-balloon.c           |   2 +-
hw/virtio/virtio-mem-pci.c           |   1 +
monitor/hmp-cmds.c                   |   2 +
monitor/qmp-cmds.c                   |   1 +
softmmu/balloon.c                    |   2 +-
stubs/uuid.c                         |   2 +-
stubs/vmgenid.c                      |   2 +-
MAINTAINERS                          |   2 +
qapi/meson.build                     |   2 +
28 files changed, 874 insertions(+), 837 deletions(-)
create mode 100644 qapi/acpi.json
create mode 100644 qapi/pci.json
[PATCH v5 0/8] user-mode: Prune build dependencies (part 2)
Posted by Philippe Mathieu-Daudé 3 years, 7 months ago
This is the second part of a series reducing user-mode
dependencies. By stripping out unused code, the build
and testing time is reduced (as is space used by objects).

Series is fully Acked.

Part 2:
- Extract code not related to user-mode from qapi/misc.json

Since v4:
- Rebased on "QOM boilerplate cleanup"
- Dropped patch #1 "target/i386: Restrict X86CPUFeatureWord"
- Added Paolo's A-b tag

Since v3:
- Rebased (Meson)
- Addressed Markus comments:
  - Use g_assert_not_reached() in stub
  - Add commit descriptions
  - Extract ACPI / PCI
  - MEMORY not extracted as no feedback from Igor/MST

Since v2:
- Addressed Igor review comments (move query-uuid to machine)
- Addressed David review comments (fix balloon documentation)

Since v1:
- Do not extract the 'add_client' command (elmarco)

CI:
https://gitlab.com/philmd/qemu/-/pipelines/189374631

Philippe Mathieu-Daudé (8):
  qapi: Restrict LostTickPolicy enum to machine code
  qapi: Correct balloon documentation
  qapi: Restrict balloon-related commands to machine code
  qapi: Restrict query-vm-generation-id command to machine code
  qapi: Restrict query-uuid command to machine code
  qapi: Restrict device memory commands to machine code
  qapi: Extract ACPI commands to 'acpi.json'
  qapi: Extract PCI commands to 'pci.json'

 qapi/acpi.json                       | 141 +++++
 qapi/machine.json                    | 388 +++++++++++++
 qapi/misc.json                       | 820 ---------------------------
 qapi/pci.json                        | 316 +++++++++++
 qapi/qapi-schema.json                |   2 +
 include/hw/acpi/acpi_dev_interface.h |   2 +-
 include/hw/mem/memory-device.h       |   2 +-
 include/hw/rtc/mc146818rtc.h         |   2 +-
 include/hw/virtio/virtio-pmem.h      |   2 +-
 include/sysemu/balloon.h             |   2 +-
 block/iscsi.c                        |   2 +-
 hw/acpi/core.c                       |   2 +-
 hw/acpi/cpu.c                        |   2 +-
 hw/acpi/memory_hotplug.c             |   3 +-
 hw/acpi/vmgenid.c                    |   2 +-
 hw/core/qdev-properties.c            |   1 +
 hw/i386/kvm/i8254.c                  |   2 +-
 hw/pci/pci-stub.c                    |   2 +-
 hw/pci/pci.c                         |   2 +-
 hw/virtio/virtio-balloon.c           |   2 +-
 hw/virtio/virtio-mem-pci.c           |   1 +
 monitor/hmp-cmds.c                   |   2 +
 monitor/qmp-cmds.c                   |   1 +
 softmmu/balloon.c                    |   2 +-
 stubs/uuid.c                         |   2 +-
 stubs/vmgenid.c                      |   2 +-
 MAINTAINERS                          |   2 +
 qapi/meson.build                     |   2 +
 28 files changed, 874 insertions(+), 837 deletions(-)
 create mode 100644 qapi/acpi.json
 create mode 100644 qapi/pci.json

-- 
2.26.2

Re: [PATCH v5 0/8] user-mode: Prune build dependencies (part 2)
Posted by Markus Armbruster 3 years, 7 months ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> This is the second part of a series reducing user-mode
> dependencies. By stripping out unused code, the build
> and testing time is reduced (as is space used by objects).
>
> Series is fully Acked.

One more:
Acked-by: Markus Armbruster <armbru@redhat.com>

I suggested commit message tweaks.  Happy to do them in my tree, if you
agree.


Re: [PATCH v5 0/8] user-mode: Prune build dependencies (part 2)
Posted by Philippe Mathieu-Daudé 3 years, 7 months ago
On 9/15/20 8:29 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> 
>> This is the second part of a series reducing user-mode
>> dependencies. By stripping out unused code, the build
>> and testing time is reduced (as is space used by objects).
>>
>> Series is fully Acked.
> 
> One more:
> Acked-by: Markus Armbruster <armbru@redhat.com>
> 
> I suggested commit message tweaks.  Happy to do them in my tree, if you
> agree.

Sure, no problem!

Thanks :)

Phil.


Re: [PATCH v5 0/8] user-mode: Prune build dependencies (part 2)
Posted by Markus Armbruster 3 years, 7 months ago
Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> This is the second part of a series reducing user-mode
> dependencies. By stripping out unused code, the build
> and testing time is reduced (as is space used by objects).
>
> Series is fully Acked.

Queued, thanks!