It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and
disable partial test-char tests.
And then fixes all unit tests failure on msys2/mingw
This fixes the reviews suggested in the mailling list
All cirrus CI are passed

Maxim Levitsky (1):
  rcu: Implement drain_call_rcu

Yonggang Luo (26):
  block: Fixes nfs compiling error on msys2/mingw
  ci: fixes msys2 build by upgrading capstone to 4.0.2
  configure: Fixes ncursesw detection under msys2/mingw and enable
    curses
  win32: Simplify gmtime_r detection direct base on
    _POSIX_THREAD_SAFE_FUNCTIONS.
  curses: Fixes curses compiling errors.
  tests: disable /char/stdio/* tests in test-char.c on win32
  tests: Fixes test-replication.c on msys2/mingw.
  tests: test-replication disable /replication/secondary/* on
    msys2/mingw.
  osdep: file locking functions are not available on Win32
  meson: Use -b to ignore CR vs. CR-LF issues on Windows
  gcrypt: test_tls_psk_init should write binary file instead text file.
  tests: Enable crypto tests under msys2/mingw
  meson: remove empty else and duplicated gio deps
  vmstate: Fixes test-vmstate.c on msys2/mingw
  cirrus: Building freebsd in a single short
  tests: Convert g_free to g_autofree macro in test-logging.c
  tests: Fixes test-io-channel-socket.c tests under msys2/mingw
  tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence
    with aio-posix.c
  tests: Fixes test-io-channel-file by mask only owner file state mask
    bits
  tests: fix test-util-sockets.c
  tests: Fixes test-qdev-global-props.c
  rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full
  ci: Enable msys2 ci in cirrus
  meson: upgrade meson for execute custom ninjatool under msys2 properly
  meson: remove --ninja option in configure.
  Revert "configure: add --ninja option"

 .cirrus.yml                      |  95 ++++++++++++-----
 block/nfs.c                      |  26 ++++-
 capstone                         |   2 +-
 configure                        |  77 ++++----------
 include/qemu/osdep.h             |   2 +-
 include/qemu/rcu.h               |   1 +
 include/sysemu/os-win32.h        |   4 +-
 meson                            |   2 +-
 meson.build                      |   6 --
 tests/crypto-tls-psk-helpers.c   |   6 +-
 tests/crypto-tls-x509-helpers.c  | 169 ++++++++++++++++++++++++++++++-
 tests/crypto-tls-x509-helpers.h  |   9 +-
 tests/qapi-schema/meson.build    |   2 +-
 tests/test-char.c                |  26 +++--
 tests/test-crypto-tlscredsx509.c |  47 +++++----
 tests/test-crypto-tlssession.c   |  68 +++++++------
 tests/test-io-channel-file.c     |  10 +-
 tests/test-io-channel-socket.c   |   2 +
 tests/test-io-channel-tls.c      |  51 ++++++----
 tests/test-logging.c             |   5 +-
 tests/test-qdev-global-props.c   |   6 +-
 tests/test-replication.c         |  22 +++-
 tests/test-util-sockets.c        |   6 +-
 tests/test-vmstate.c             |   3 +-
 ui/curses.c                      |  14 +--
 util/aio-win32.c                 |  11 +-
 util/oslib-win32.c               |   2 +-
 util/rcu.c                       |  55 ++++++++++
 28 files changed, 514 insertions(+), 215 deletions(-)

-- 
2.28.0.windows.1

Patchew URL: https://patchew.org/QEMU/20200912224431.1428-1-luoyonggang@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

N/A. Internal error while reading log file



The full log is available at
http://patchew.org/logs/20200912224431.1428-1-luoyonggang@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

On Sun, Sep 13, 2020 at 7:07 AM <no-reply@patchew.org> wrote:
>
> Patchew URL:
https://patchew.org/QEMU/20200912224431.1428-1-luoyonggang@gmail.com/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> N/A. Internal error while reading log file
>
>
>
> The full log is available at
>
http://patchew.org/logs/20200912224431.1428-1-luoyonggang@gmail.com/testing.checkpatch/?type=message
.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
I also have a question about this,  This series seems to have some coding
style problems, but where
to find the logging, seems the logs of patchew are failed(out of disk)


--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

On 13/09/2020 00.44, Yonggang Luo wrote:
> It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and
> disable partial test-char tests.
> And then fixes all unit tests failure on msys2/mingw
> This fixes the reviews suggested in the mailling list
> All cirrus CI are passed

 Hi,

since you're very often sending new versions of your patch series, could
you please add a history to the cover letter to say what you changed in
each version? Otherwise, your work is very hard to follow.
I'd also suggest to really slow down the sending a little bit. Let your
patches mature in your tests first, then send out a new series only if
you feel that they are really ready. Nobody has the bandwith to review a
patch series with 27 patches each day...

 Thanks,
  Thomas

On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth <thuth@redhat.com> wrote:

> On 13/09/2020 00.44, Yonggang Luo wrote:
> > It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and
> > disable partial test-char tests.
> > And then fixes all unit tests failure on msys2/mingw
> > This fixes the reviews suggested in the mailling list
> > All cirrus CI are passed
>
>  Hi,
>
> since you're very often sending new versions of your patch series, could
> you please add a history to the cover letter to say what you changed in
> each version? Otherwise, your work is very hard to follow.
> I'd also suggest to really slow down the sending a little bit. Let your
> patches mature in your tests first, then send out a new series only if
> you feel that they are really ready. Nobody has the bandwith to review a
> patch series with 27 patches each day...
>
> Thanks, I am learning how to submit patches properly, in old days,  when I
am using pull request on github have no such problems. easy to follow up

>  Thanks,
>   Thomas
>
>
>

-- 
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

Am 14.09.20 um 08:27 schrieb 罗勇刚(Yonggang Luo):

>
> Thanks, I am learning how to submit patches properly, in old days, 
> when I am using pull request on github have no such problems. easy to
> follow up


May I also ask you to send text-only e-mails? Your HTML e-mails are
really hard to read.

Thanks,

Stefan Weil

On Mon, Sep 14, 2020 at 2:38 PM Stefan Weil <sw@weilnetz.de> wrote:
>
> Am 14.09.20 um 08:27 schrieb 罗勇刚(Yonggang Luo):
>
>
> Thanks, I am learning how to submit patches properly, in old days,  when
I am using pull request on github have no such problems. easy to follow up
>
>
> May I also ask you to send text-only e-mails? Your HTML e-mails are
really hard to read.
>
> Thanks,
>
> Stefan Weil
>
>
Sorry, I am using gmail to send, I'll review the email format in latter
messages


--
         此致
礼
罗勇刚
Yours
    sincerely,
Yonggang Luo

On 9/14/20 8:27 AM, 罗勇刚(Yonggang Luo) wrote:
> 
> 
> On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
> 
>     On 13/09/2020 00.44, Yonggang Luo wrote:
>     > It first introduce msys2 CI on cirrus by fixes nfs, capstone,
>     curses and
>     > disable partial test-char tests.
>     > And then fixes all unit tests failure on msys2/mingw
>     > This fixes the reviews suggested in the mailling list
>     > All cirrus CI are passed
> 
>      Hi,
> 
>     since you're very often sending new versions of your patch series, could
>     you please add a history to the cover letter to say what you changed in
>     each version? Otherwise, your work is very hard to follow.
>     I'd also suggest to really slow down the sending a little bit. Let your
>     patches mature in your tests first, then send out a new series only if
>     you feel that they are really ready. Nobody has the bandwith to review a
>     patch series with 27 patches each day...
> 
> Thanks, I am learning how to submit patches properly, in old days,  when
> I am using pull request on github have no such problems. easy to follow up 

GitHub pull-request have the same problem, you can update its patches
and re-reviewing on top is very difficult. Some old review comments
even get deleted. At least having email archive allow us to look
back for older versions/comments.

Regards,

Phil.